Issue 2482943002: Include build_config.h in variations_url_constants.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2482943002: Include build_config.h in variations_url_constants.cc. (Closed)

Created:
4 years, 1 month ago by Alexei Svitkine (slow)

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Include build_config.h in variations_url_constants.cc. The file checks #if defined(OS_ANDROID), but that's not set unless build_config.h is included. This change should result in the URL for variations seed fetches being actually changed for Android Chrome. BUG=635680 Review-Url: https://codereview.chromium.org/2474313005 Cr-Commit-Position: refs/heads/master@{#430129} (cherry picked from commit 0292659d45ce31e698ea8329f8aef66c8ac1c9e0) Committed: https://chromium.googlesource.com/chromium/src/+/58621a9010d93459e681e634068b225b0f5fceb5

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	components/variations/variations_url_constants.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Alexei Svitkine (slow)

4 years, 1 month ago (2016-11-07 18:04:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
58621a9010d93459e681e634068b225b0f5fceb5.