Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2474313005: Include build_config.h in variations_url_constants.cc. (Closed)

Created:
4 years, 1 month ago by Alexei Svitkine (slow)
Modified:
4 years, 1 month ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include build_config.h in variations_url_constants.cc. The file checks #if defined(OS_ANDROID), but that's not set unless build_config.h is included. This change should result in the URL for variations seed fetches being actually changed for Android Chrome. BUG=635680 Committed: https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0 Cr-Commit-Position: refs/heads/master@{#430129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/variations/variations_url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Alexei Svitkine (slow)
4 years, 1 month ago (2016-11-04 21:41:13 UTC) #2
jwd
lgtm
4 years, 1 month ago (2016-11-04 21:41:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474313005/1
4 years, 1 month ago (2016-11-04 21:42:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/174903)
4 years, 1 month ago (2016-11-04 23:03:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474313005/1
4 years, 1 month ago (2016-11-05 02:04:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 02:38:34 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 02:40:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0
Cr-Commit-Position: refs/heads/master@{#430129}

Powered by Google App Engine
This is Rietveld 408576698