[ic] Resurrect access checks for primitive and global proxy receivers.

[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts
  for primitive receivers.
- Equality check of an execution-time and a compile-time native contexts
  or equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
Committed: https://crrev.com/03a1eb5ad76e5d3290e91043144e6ad4c41de8c4
Cr-Commit-Position: refs/heads/master@{#40829}

[Igor Sheludko, 2016-11-07 15:12:24]

Description was changed from

==========
[ic] Resurrect access checks for primitive and global proxy receivers

BUG=v8:5561
==========

to

==========
[ic] Resurrect access checks for primitive and global proxy receivers

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts for
primitive receivers.
- Equality check of an execution-time and a compile-time native contexts or
equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

[Igor Sheludko, 2016-11-07 15:12:38]

Description was changed from

==========
[ic] Resurrect access checks for primitive and global proxy receivers

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts for
primitive receivers.
- Equality check of an execution-time and a compile-time native contexts or
equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

to

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts for
primitive receivers.
- Equality check of an execution-time and a compile-time native contexts or
equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

[Igor Sheludko, 2016-11-07 15:13:12]

Description was changed from

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts for
primitive receivers.
- Equality check of an execution-time and a compile-time native contexts or
equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

to

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts 
  for primitive receivers.
- Equality check of an execution-time and a compile-time native contexts
  or equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

[Igor Sheludko, 2016-11-07 16:57:15]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-11-07 16:57:21]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-11-07 16:57:29]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 16:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-07 16:58:48]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 16:58:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-07 17:01:07]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-11-07 17:01:08]

PTAL

[commit-bot: I haz the power, 2016-11-07 17:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:01:42]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12048)

[Igor Sheludko, 2016-11-07 17:05:14]

Patchset #2 (id:50001) has been deleted

[Igor Sheludko, 2016-11-07 17:10:12]

Patchset #1 (id:30001) has been deleted

[Igor Sheludko, 2016-11-07 17:10:17]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:10:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-07 17:10:55]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:11:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:37:07]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-11-08 10:56:53]

lgtm

https://codereview.chromium.org/2482913002/diff/90001/src/ic/handler-compiler.h
File src/ic/handler-compiler.h (right):

https://codereview.chromium.org/2482913002/diff/90001/src/ic/handler-compiler...
src/ic/handler-compiler.h:87: // than given |native_context_cell|.
nit: s/than/as the/

https://codereview.chromium.org/2482913002/diff/90001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/2482913002/diff/90001/test/cctest/test-api.cc...
test/cctest/test-api.cc:22763: +    // Create a context and set an x property on
it's global object.
nit: s/it's/its/

[Igor Sheludko, 2016-11-08 12:07:56]

https://codereview.chromium.org/2482913002/diff/90001/src/ic/handler-compiler.h
File src/ic/handler-compiler.h (right):

https://codereview.chromium.org/2482913002/diff/90001/src/ic/handler-compiler...
src/ic/handler-compiler.h:87: // than given |native_context_cell|.
On 2016/11/08 10:56:53, Jakob Kummerow wrote:
> nit: s/than/as the/

Done.

https://codereview.chromium.org/2482913002/diff/90001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/2482913002/diff/90001/test/cctest/test-api.cc...
test/cctest/test-api.cc:22763: +    // Create a context and set an x property on
it's global object.
On 2016/11/08 10:56:53, Jakob Kummerow wrote:
> nit: s/it's/its/

Done.

[Igor Sheludko, 2016-11-08 12:08:00]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-11-08 12:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2482913002/#ps110001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-11-08 12:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 12:34:53]

Description was changed from

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts 
  for primitive receivers.
- Equality check of an execution-time and a compile-time native contexts
  or equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

to

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts 
  for primitive receivers.
- Equality check of an execution-time and a compile-time native contexts
  or equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

[commit-bot: I haz the power, 2016-11-08 12:34:54]

Committed patchset #3 (id:110001)

[commit-bot: I haz the power, 2016-11-17 22:25:55]

Description was changed from

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts 
  for primitive receivers.
- Equality check of an execution-time and a compile-time native contexts
  or equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561
==========

to

==========
[ic] Resurrect access checks for primitive and global proxy receivers.

The access check is generated as a:
- Equality check of an execution-time and a compile-time native contexts
  for primitive receivers.
- Equality check of an execution-time and a compile-time native contexts
  or equality check of a respective security tokens for global proxy receivers.
- No-op for other kinds of receivers.

BUG=v8:5561

Committed: https://crrev.com/03a1eb5ad76e5d3290e91043144e6ad4c41de8c4
Cr-Commit-Position: refs/heads/master@{#40829}
==========

[commit-bot: I haz the power, 2016-11-17 22:25:56]

Patchset 3 (id:??) landed as
https://crrev.com/03a1eb5ad76e5d3290e91043144e6ad4c41de8c4
Cr-Commit-Position: refs/heads/master@{#40829}