Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: src/ic/handler-configuration-inl.h

Issue 2482913002: [ic] Resurrect access checks for primitive and global proxy receivers. (Closed)
Patch Set: Addressing comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/handler-configuration.h ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/handler-configuration-inl.h
diff --git a/src/ic/handler-configuration-inl.h b/src/ic/handler-configuration-inl.h
index 573922ae3e618ecd3e2f50d1b2b3e785f7e8a829..b7334a7c030f74c9aae490d0cf1fbd423eed2490 100644
--- a/src/ic/handler-configuration-inl.h
+++ b/src/ic/handler-configuration-inl.h
@@ -29,12 +29,23 @@ Handle<Object> LoadHandler::LoadConstant(Isolate* isolate, int descriptor) {
return handle(Smi::FromInt(config), isolate);
}
+Handle<Object> LoadHandler::EnableAccessCheckOnReceiver(
+ Isolate* isolate, Handle<Object> smi_handler) {
+ int config = Smi::cast(*smi_handler)->value();
+#ifdef DEBUG
+ Kind kind = KindBits::decode(config);
+ DCHECK_NE(kForElements, kind);
+#endif
+ config = DoAccessCheckOnReceiverBits::update(config, true);
+ return handle(Smi::FromInt(config), isolate);
+}
+
Handle<Object> LoadHandler::EnableNegativeLookupOnReceiver(
Isolate* isolate, Handle<Object> smi_handler) {
int config = Smi::cast(*smi_handler)->value();
#ifdef DEBUG
Kind kind = KindBits::decode(config);
- DCHECK(kind == kForFields || kind == kForConstants);
+ DCHECK_NE(kForElements, kind);
#endif
config = DoNegativeLookupOnReceiverBits::update(config, true);
return handle(Smi::FromInt(config), isolate);
« no previous file with comments | « src/ic/handler-configuration.h ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698