Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2482793007: Add testing spec for new Nougat tester bot on chromium.android.fyi (Closed)

Created:
4 years, 1 month ago by bpastene
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add testing spec for new Nougat tester bot on chromium.android.fyi Copy-pasted from Marshmallow 64 bit tester (+ s/MMB29Q/NRD91N/) BUG=663803 Committed: https://crrev.com/8b9fa29548526db08c080792fce1eb9bc0d3c7b9 Cr-Commit-Position: refs/heads/master@{#439167}

Patch Set 1 #

Patch Set 2 : switch to android.fyi #

Total comments: 2

Patch Set 3 : no blimp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1045 lines, -0 lines) Patch
M testing/buildbot/chromium.android.fyi.json View 1 2 1 chunk +1045 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bpastene
lpat recipe config: https://codereview.chromium.org/2489853003
4 years, 1 month ago (2016-11-09 20:04:11 UTC) #2
jbudorick
This is fine, but as mentioned in the other review, I think this bot should ...
4 years, 1 month ago (2016-11-09 20:07:52 UTC) #3
ghost stip (do not use)
https://s-media-cache-ak0.pinimg.com/originals/19/ef/9a/19ef9a4820f70eca4ff93e11f6f3d608.jpg
4 years, 1 month ago (2016-11-16 21:16:19 UTC) #4
bpastene
ok, moved it to fyi
4 years ago (2016-12-16 02:23:34 UTC) #6
jbudorick
lgtm w/ nits https://codereview.chromium.org/2482793007/diff/20001/testing/buildbot/chromium.android.fyi.json File testing/buildbot/chromium.android.fyi.json (right): https://codereview.chromium.org/2482793007/diff/20001/testing/buildbot/chromium.android.fyi.json#newcode457 testing/buildbot/chromium.android.fyi.json:457: "override_isolate_target": "blimp_test_apk", We can omit this ...
4 years ago (2016-12-16 15:32:07 UTC) #7
bpastene
On 2016/12/16 15:32:07, jbudorick wrote: > lgtm w/ nits > > https://codereview.chromium.org/2482793007/diff/20001/testing/buildbot/chromium.android.fyi.json > File testing/buildbot/chromium.android.fyi.json ...
4 years ago (2016-12-16 17:37:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482793007/40001
4 years ago (2016-12-16 17:37:53 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 19:33:03 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b9fa29548526db08c080792fce1eb9bc0d3c7b9
Cr-Commit-Position: refs/heads/master@{#439167}

Powered by Google App Engine
This is Rietveld 408576698