fix git-cl-try without parameters

fix git-cl-try without parameters

Master names were confused with bucket names

R=tandrii@chromium.org, qyearsley@chromium.org
BUG=661580
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e4f0fe02a97d526b565fc13152436f6f165e05c6

[nodir, 2016-11-04 21:53:42]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:53:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nodir, 2016-11-04 21:55:14]

PTAL

[commit-bot: I haz the power, 2016-11-04 22:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:00:05]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/324a271f98c9ba10)

[nodir, 2016-11-04 22:02:46]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[qyearsley, 2016-11-04 22:02:52]

LGTM, thanks for finding and fixing this

https://codereview.chromium.org/2482523002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2482523002/diff/1/git_cl.py#newcode361
git_cl.py:361: return {MASTER_PREFIX + m: b for m, b in masters.iteritems()}
Could be changed to:

return {_prefix_master(m): b for m, b in masters.iteritems()}

[commit-bot: I haz the power, 2016-11-04 22:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nodir, 2016-11-04 22:04:04]

https://codereview.chromium.org/2482523002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2482523002/diff/1/git_cl.py#newcode361
git_cl.py:361: return {MASTER_PREFIX + m: b for m, b in masters.iteritems()}
On 2016/11/04 22:02:52, qyearsley wrote:
> Could be changed to:
> 
> return {_prefix_master(m): b for m, b in masters.iteritems()}

I don't like _prefix_master. It assumes that no master starts with "master.".
Better not to make assumptions when we know for sure that this is a master name
and not a bucket name.

[qyearsley, 2016-11-04 22:05:13]

On 2016/11/04 at 22:04:04, nodir wrote:
> https://codereview.chromium.org/2482523002/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/2482523002/diff/1/git_cl.py#newcode361
> git_cl.py:361: return {MASTER_PREFIX + m: b for m, b in masters.iteritems()}
> On 2016/11/04 22:02:52, qyearsley wrote:
> > Could be changed to:
> > 
> > return {_prefix_master(m): b for m, b in masters.iteritems()}
> 
> I don't like _prefix_master. It assumes that no master starts with "master.".
Better not to make assumptions when we know for sure that this is a master name
and not a bucket name.

Yeah, that makes sense.

[commit-bot: I haz the power, 2016-11-04 22:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:05:45]

Dry run: This issue passed the CQ dry run.

[nodir, 2016-11-04 22:37:33]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:37:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 22:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:40:29]

Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/324a4f3b39de0f10)

[nodir, 2016-11-04 23:19:32]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-11-04 23:19:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 23:23:32]

Description was changed from

==========
fix git-cl-try without parameters

Master names were confused with bucket names

R=tandrii@chromium.org, qyearsley@chromium.org
BUG=661580
==========

to

==========
fix git-cl-try without parameters

Master names were confused with bucket names

R=tandrii@chromium.org, qyearsley@chromium.org
BUG=661580

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e4f0fe02a97d52...
==========

[commit-bot: I haz the power, 2016-11-04 23:23:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e4f0fe02a97d52...