Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: git_cl.py

Issue 2482523002: fix git-cl-try without parameters (Closed)
Patch Set: masters can be None Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 66bb76831aa3c1608b5b06b7585353be41579cb4..983374713a4f80cb570491eb6c5fa532eca6b565 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -350,7 +350,7 @@ def _get_bucket_map(changelist, options, option_parser):
change = changelist.GetChange(
changelist.GetCommonAncestorWithUpstream(), None)
# Get try masters from PRESUBMIT.py files.
- return presubmit_support.DoGetTryMasters(
+ masters = presubmit_support.DoGetTryMasters(
change=change,
changed_files=change.LocalPaths(),
repository_root=settings.GetRoot(),
@@ -358,6 +358,9 @@ def _get_bucket_map(changelist, options, option_parser):
project=None,
verbose=options.verbose,
output_stream=sys.stdout)
+ if masters is None:
+ return None
+ return {MASTER_PREFIX + m: b for m, b in masters.iteritems()}
if options.bucket:
return {options.bucket: {b: [] for b in options.bot}}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698