Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2482163002: [heap] Remove js call rate heuristic from memory reducer. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove js call rate heuristic from memory reducer. This is an experiment to check whether the heuristics is still useful. BUG= Committed: https://crrev.com/984e6aed3e8c597e8985ea53225f142257037a68 Cr-Commit-Position: refs/heads/master@{#40833}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -55 lines) Patch
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/memory-reducer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 4 chunks +3 lines, -17 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 1 month ago (2016-11-08 13:03:40 UTC) #2
Michael Lippautz
lgtm, I would assume that infinite scrolling suffers from this one :/
4 years, 1 month ago (2016-11-08 13:16:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482163002/20001
4 years, 1 month ago (2016-11-08 13:19:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 13:47:23 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/984e6aed3e8c597e8985ea53225f142257037a68
Cr-Commit-Position: refs/heads/master@{#40833}

Powered by Google App Engine
This is Rietveld 408576698