Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2482163002: [heap] Remove js call rate heuristic from memory reducer. (Closed)
Patch Set: fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index d7dec934e72e74d5fedd2975548b27d3fb95f93e..e8b8209c0ce432c9d2c2cdfc5aaa913f16f0d257 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -6408,30 +6408,6 @@ TEST(Regress519319) {
}
-HEAP_TEST(TestMemoryReducerSampleJsCalls) {
- CcTest::InitializeVM();
- v8::HandleScope scope(CcTest::isolate());
- Heap* heap = CcTest::heap();
- Isolate* isolate = CcTest::i_isolate();
- MemoryReducer* memory_reducer = heap->memory_reducer_;
- memory_reducer->SampleAndGetJsCallsPerMs(0);
- isolate->IncrementJsCallsFromApiCounter();
- isolate->IncrementJsCallsFromApiCounter();
- isolate->IncrementJsCallsFromApiCounter();
- double calls_per_ms = memory_reducer->SampleAndGetJsCallsPerMs(1);
- CheckDoubleEquals(3, calls_per_ms);
-
- calls_per_ms = memory_reducer->SampleAndGetJsCallsPerMs(2);
- CheckDoubleEquals(0, calls_per_ms);
-
- isolate->IncrementJsCallsFromApiCounter();
- isolate->IncrementJsCallsFromApiCounter();
- isolate->IncrementJsCallsFromApiCounter();
- isolate->IncrementJsCallsFromApiCounter();
- calls_per_ms = memory_reducer->SampleAndGetJsCallsPerMs(4);
- CheckDoubleEquals(2, calls_per_ms);
-}
-
HEAP_TEST(Regress587004) {
FLAG_concurrent_sweeping = false;
#ifdef VERIFY_HEAP
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698