Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2482153002: WebRTC: Set the right path to clean_symlinks.py (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Set the right path to clean_symlinks.py The path calculated in https://codereview.chromium.org/2484803004 missed the fact that the checkout root was the dir that was passed to the script. Update the cleanup_symlinks.py script to set the right path and clarify that the directory argument to pass to it is expected to be the checkout root (not the path to the src/ dir). Also make the script not fail if the file is not found (a new bot don't have it, but still has the checkout root). BUG=663278 TBR=ehmaldonado@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/11a160e371823f1c6bedca71a54069b40c810075

Patch Set 1 #

Patch Set 2 : Simplify logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py View 1 1 chunk +10 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_chromium
*sigh* I'm glad I did this in client.webrtc.fyi
4 years, 1 month ago (2016-11-08 11:39:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482153002/1
4 years, 1 month ago (2016-11-08 11:39:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482153002/20001
4 years, 1 month ago (2016-11-08 11:45:52 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 11:55:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/11a160e371823f1c6bed...

Powered by Google App Engine
This is Rietveld 408576698