WebRTC: Cleanup symlinks before bot_update

WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.
This is needed in order for us to start moving away from the symlinks.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
TESTED=
Ran scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py with empty
argument and passing the path to a valid checkout.

Committed: https://chromium.googlesource.com/chromium/tools/build/+/0b9ea04a6d27396523b240d61e90c824bf6dc90f

[kjellander_chromium, 2016-11-08 07:51:22]

Description was changed from

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.

BUG=663278
==========

to

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.

BUG=663278
==========

[kjellander_chromium, 2016-11-08 07:51:22]

kjellander@chromium.org changed reviewers:
+ machenbach@chromium.org

[kjellander_chromium, 2016-11-08 07:51:45]

Description was changed from

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.

BUG=663278
==========

to

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
==========

[kjellander_chromium, 2016-11-08 07:52:22]

Description was changed from

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
==========

to

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.
This is needed in order for us to start moving away from the symlinks.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
==========

[kjellander_chromium, 2016-11-08 07:52:28]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 07:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-11-08 07:55:57]

Description was changed from

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.
This is needed in order for us to start moving away from the symlinks.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
==========

to

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.
This is needed in order for us to start moving away from the symlinks.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
TESTED=
Ran scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py with empty
argument and passing the path to a valid checkout.
==========

[Michael Achenbach, 2016-11-08 09:11:47]

lgtm

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py (right):

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py:14: if not
args or len(args) != 1:
nit:
if len(args) != 1:
should be enough, since the way you pass it below makes sure it's a list.

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py:24: if not
os.path.isfile(setup_links_file):
Does "isfile" imply "exists"? Or can it raise?

[ehmaldonado_chromium, 2016-11-08 10:43:25]

ehmaldonado@chromium.org changed reviewers:
+ ehmaldonado@chromium.org

[ehmaldonado_chromium, 2016-11-08 10:43:26]

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py (right):

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py:24: if not
os.path.isfile(setup_links_file):
On 2016/11/08 09:11:47, machenbach (slow) wrote:
> Does "isfile" imply "exists"? Or can it raise?

It doesn't raise.

[kjellander_chromium, 2016-11-08 11:04:40]

Thanks, submitting PS#3.

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py (right):

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py:14: if not
args or len(args) != 1:
On 2016/11/08 09:11:47, machenbach (slow) wrote:
> nit:
> if len(args) != 1:
> should be enough, since the way you pass it below makes sure it's a list.

Done.

https://codereview.chromium.org/2484803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py:24: if not
os.path.isfile(setup_links_file):
On 2016/11/08 10:43:25, ehmaldonado_chromium wrote:
> On 2016/11/08 09:11:47, machenbach (slow) wrote:
> > Does "isfile" imply "exists"? Or can it raise?
> 
> It doesn't raise.

Acknowledged.

[kjellander_chromium, 2016-11-08 11:04:50]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-11-08 11:04:50]

The CQ bit was unchecked by kjellander@chromium.org

[kjellander_chromium, 2016-11-08 11:04:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2484803004/#ps40001
(title: "Review comments")

[kjellander_chromium, 2016-11-08 11:04:51]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:04:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-11-08 11:05:08]

The CQ bit was unchecked by kjellander@chromium.org

[kjellander_chromium, 2016-11-08 11:05:55]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-11-08 11:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2484803004/#ps60001
(title: "Rebased new Win8 and Win10 bots")

[commit-bot: I haz the power, 2016-11-08 11:06:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 11:16:07]

Description was changed from

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.
This is needed in order for us to start moving away from the symlinks.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
TESTED=
Ran scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py with empty
argument and passing the path to a valid checkout.
==========

to

==========
WebRTC: Cleanup symlinks before bot_update

Call setup_links.py --clean-only before bot_update
runs to ensure all links are cleaned up to avoid conflicts
during patching/syncing.
This is needed in order for us to start moving away from the symlinks.

Only deploy at client.webrtc.fyi to be sure not breaking all bots at once.

BUG=663278
TESTED=
Ran scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py with empty
argument and passing the path to a valid checkout.

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0b9ea04a6d27396523b2...
==========

[commit-bot: I haz the power, 2016-11-08 11:16:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/0b9ea04a6d27396523b2...