DevTools: introduce beautiful checkmarks in navigator and editor tabs

DevTools: introduce beautiful checkmarks in navigator and editor tabs

These checkmarks should designate that the file syncs with a network
resource.

BUG=649837
R=dgozman

Committed: https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd
Cr-Commit-Position: refs/heads/master@{#431048}

[lushnikov, 2016-11-08 05:37:52]

please, take a look!

[lushnikov, 2016-11-08 05:53:56]

FYI: screenshot's in the bug.

[lushnikov, 2016-11-08 10:12:09]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 10:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 11:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:52:52]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-08 20:52:29]

lgtm

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
(right):

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:559:
this._tabbedPane.setTabIcon(tabId, 'smallicon-checkmark');
Let's have a tooltip explaining this checkmark (similar to navigator's one).

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css
(right):

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css:58:
cursor: help
- missing semicolon;
- I cannot remember a single help cursor in DevTools.

[lushnikov, 2016-11-09 19:30:20]

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
(right):

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:559:
this._tabbedPane.setTabIcon(tabId, 'smallicon-checkmark');
On 2016/11/08 20:52:29, dgozman wrote:
> Let's have a tooltip explaining this checkmark (similar to navigator's one).

Done.

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css
(right):

https://codereview.chromium.org/2482073002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css:58:
cursor: help
On 2016/11/08 20:52:29, dgozman wrote:
> - missing semicolon;
> - I cannot remember a single help cursor in DevTools.

Dropped the cursor.

https://codereview.chromium.org/2482073002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
(right):

https://codereview.chromium.org/2482073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js:5:
WebInspector.PersistenceUtils = class {
LinkDecorator will go here as well

[lushnikov, 2016-11-09 19:30:39]

Please, take another look

[dgozman, 2016-11-09 19:58:26]

lgtm

https://codereview.chromium.org/2482073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2482073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:114:
'smallicon-checkmark-mask': {x: -100, y: -20, width: 10, height: 10,
spritesheet: 'smallicons', isMask: true},
Let's name these checkmark and green-checkmark, as we don't use -mask suffix
anymore.

[lushnikov, 2016-11-09 20:29:43]

https://codereview.chromium.org/2482073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2482073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:114:
'smallicon-checkmark-mask': {x: -100, y: -20, width: 10, height: 10,
spritesheet: 'smallicons', isMask: true},
On 2016/11/09 19:58:26, dgozman wrote:
> Let's name these checkmark and green-checkmark, as we don't use -mask suffix
> anymore.

Thanks, done

[lushnikov, 2016-11-09 20:29:46]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-09 20:29:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2482073002/#ps40001
(title: "rename icons")

[commit-bot: I haz the power, 2016-11-09 20:30:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 22:10:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 22:24:46]

Description was changed from

==========
DevTools: introduce beautiful checkmarks in navigator and editor tabs

These checkmarks should designate that the file syncs with a network
resource.

BUG=649837
R=dgozman
==========

to

==========
DevTools: introduce beautiful checkmarks in navigator and editor tabs

These checkmarks should designate that the file syncs with a network
resource.

BUG=649837
R=dgozman

Committed: https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd
Cr-Commit-Position: refs/heads/master@{#431048}
==========

[commit-bot: I haz the power, 2016-11-09 22:24:47]

Patchset 3 (id:??) landed as
https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd
Cr-Commit-Position: refs/heads/master@{#431048}