DevTools: introduce sync checkmarks icons in StylesSidebarPane.

DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark to the links in the
StylesSidebarPane.

BUG=649837
R=dgozman

Committed: https://crrev.com/adbb620970bd4408861f6a4cf6acb5545bae535c
Cr-Commit-Position: refs/heads/master@{#431159}

[lushnikov, 2016-11-09 18:21:53]

please, take a look

[lushnikov, 2016-11-09 18:23:29]

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:496: *
@return {string}
it feels daunting to return a string here, but if we want a tooltip, then this
should be the
WI.Icon instance

[dgozman, 2016-11-09 18:58:48]

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:52: static
registerIconProvider(iconProvider) {
If you only support a single one, call it setDecorator.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:331: var
anchor = this._createAnchor(classes, true);
This should be a parameter of linkifier.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:491:
WebInspector.LinkifierIconProvider = function() {};
LinkDecorator

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:496: *
@return {string}
On 2016/11/09 18:23:28, lushnikov wrote:
> it feels daunting to return a string here, but if we want a tooltip, then this
> should be the
> WI.Icon instance

Let's go with WI.Icon.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:498:
iconType: function(uiSourceCode) {}
linkIcon

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:502:
IconChanged: Symbol('IconChanged')
LinkIconChanged

[lushnikov, 2016-11-09 21:46:51]

all done, please take a look

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:52: static
registerIconProvider(iconProvider) {
On 2016/11/09 18:58:48, dgozman wrote:
> If you only support a single one, call it setDecorator.

Done.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:331: var
anchor = this._createAnchor(classes, true);
On 2016/11/09 18:58:48, dgozman wrote:
> This should be a parameter of linkifier.

Done.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:491:
WebInspector.LinkifierIconProvider = function() {};
On 2016/11/09 18:58:48, dgozman wrote:
> LinkDecorator

Done.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:496: *
@return {string}
On 2016/11/09 18:23:28, lushnikov wrote:
> it feels daunting to return a string here, but if we want a tooltip, then this
> should be the
> WI.Icon instance

Done.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:498:
iconType: function(uiSourceCode) {}
On 2016/11/09 18:58:48, dgozman wrote:
> linkIcon

Done.

https://codereview.chromium.org/2487293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:502:
IconChanged: Symbol('IconChanged')
On 2016/11/09 18:58:48, dgozman wrote:
> LinkIconChanged

Done.

[lushnikov, 2016-11-09 21:46:56]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 21:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-09 22:33:04]

Description was changed from

==========
DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark in the links in the
StylesSidebarPane.

BUG=none
R=dgozman
==========

to

==========
DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark to the links in the
StylesSidebarPane.

BUG=649837
R=dgozman
==========

[commit-bot: I haz the power, 2016-11-09 23:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 23:33:06]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-10 01:01:43]

lgtm

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:55:
console.assert(!WebInspector.Linkifier._decorator, 'Cannot re-register icon
provider.');
... link decorator

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:67: for
(var anchor of anchors)
s/anchor/link/g

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:68:
WebInspector.Linkifier._decorateLink(anchor);
_updateAnchorDecorations

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:73: for
(var target of this._anchorsByTarget.keysArray()) {
for (var anchors of this._anchorsByTarget.values()) {
  ...
}

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:143: *
@param {?WebInspector.UILocation} uiLocation
Let's not accept null.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:165: var
uiSourceCode = anchor[WebInspector.Linkifier._uiLocationSymbol].uiSourceCode;
nullify this.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:431: var
icon = anchor.querySelector('span[is=ui-icon]');
Put this under symbol instead.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:434: var
newIcon = WebInspector.Linkifier._decorator.linkIcon(uiLocation.uiSourceCode);
reuse icon variable

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:439: //    
  if (uiLocation.uiSourceCode.name().endsWith("common.scss"))
:-)

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:21: var
iconProvider = new WebInspector.PersistenceUtils.LinkDecorator(this);
linkDecorator

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
(right):

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js:27:
constructor(persistence) {
JSDoc

[lushnikov, 2016-11-10 01:13:45]

All done, thanks!

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:55:
console.assert(!WebInspector.Linkifier._decorator, 'Cannot re-register icon
provider.');
On 2016/11/10 01:01:43, dgozman wrote:
> ... link decorator

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:67: for
(var anchor of anchors)
On 2016/11/10 01:01:43, dgozman wrote:
> s/anchor/link/g

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:68:
WebInspector.Linkifier._decorateLink(anchor);
On 2016/11/10 01:01:43, dgozman wrote:
> _updateAnchorDecorations

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:73: for
(var target of this._anchorsByTarget.keysArray()) {
On 2016/11/10 01:01:43, dgozman wrote:
> for (var anchors of this._anchorsByTarget.values()) {
>   ...
> }

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:143: *
@param {?WebInspector.UILocation} uiLocation
On 2016/11/10 01:01:43, dgozman wrote:
> Let's not accept null.

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:165: var
uiSourceCode = anchor[WebInspector.Linkifier._uiLocationSymbol].uiSourceCode;
On 2016/11/10 01:01:43, dgozman wrote:
> nullify this.

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:431: var
icon = anchor.querySelector('span[is=ui-icon]');
On 2016/11/10 01:01:43, dgozman wrote:
> Put this under symbol instead.

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:434: var
newIcon = WebInspector.Linkifier._decorator.linkIcon(uiLocation.uiSourceCode);
On 2016/11/10 01:01:43, dgozman wrote:
> reuse icon variable

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:439: //    
  if (uiLocation.uiSourceCode.name().endsWith("common.scss"))
On 2016/11/10 01:01:43, dgozman wrote:
> :-)

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:21: var
iconProvider = new WebInspector.PersistenceUtils.LinkDecorator(this);
On 2016/11/10 01:01:43, dgozman wrote:
> linkDecorator

Done.

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
(right):

https://codereview.chromium.org/2487293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js:27:
constructor(persistence) {
On 2016/11/10 01:01:43, dgozman wrote:
> JSDoc

Done.

[lushnikov, 2016-11-10 01:13:58]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-10 01:13:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2487293002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-10 01:14:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 03:14:28]

Description was changed from

==========
DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark to the links in the
StylesSidebarPane.

BUG=649837
R=dgozman
==========

to

==========
DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark to the links in the
StylesSidebarPane.

BUG=649837
R=dgozman
==========

[commit-bot: I haz the power, 2016-11-10 03:14:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 03:15:56]

Description was changed from

==========
DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark to the links in the
StylesSidebarPane.

BUG=649837
R=dgozman
==========

to

==========
DevTools: introduce sync checkmarks icons in StylesSidebarPane.

This patch introduces the green checkmark to the links in the
StylesSidebarPane.

BUG=649837
R=dgozman

Committed: https://crrev.com/adbb620970bd4408861f6a4cf6acb5545bae535c
Cr-Commit-Position: refs/heads/master@{#431159}
==========

[commit-bot: I haz the power, 2016-11-10 03:15:57]

Patchset 4 (id:??) landed as
https://crrev.com/adbb620970bd4408861f6a4cf6acb5545bae535c
Cr-Commit-Position: refs/heads/master@{#431159}