Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/public/platform/WebInputEvent.h

Issue 2481943002: Fix backspace double occuring on PDF files. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebInputEvent.h
diff --git a/third_party/WebKit/public/platform/WebInputEvent.h b/third_party/WebKit/public/platform/WebInputEvent.h
index 43349d55392bfd07fde5960bfb8649effe5b3696..c22e1e94506c961528412a470c5f46a5a190bf86 100644
--- a/third_party/WebKit/public/platform/WebInputEvent.h
+++ b/third_party/WebKit/public/platform/WebInputEvent.h
@@ -341,13 +341,13 @@ class WebKeyboardEvent : public WebInputEvent {
// keyboard event handling changes. It also mentions the list of keys
// which don't have associated character events.
bool isCharacterKey() const {
-#if 0
+ // TODO(dtapuska): Determine if we can remove this method and just
+ // not actually generate events for these instead of filtering them out.
switch (windowsKeyCode) {
- case VKEY_BACK:
- case VKEY_ESCAPE:
+ case 0x08: // VK_BACK
+ case 0x1b: // VK_ESCAPE
return false;
}
-#endif
return true;
}
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698