components/cloud_devices/common/cloud_devices_urls.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cloud_devices/common/cloud_devices_urls.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cloud_devices/common/cloud_devices_urls.cc

diff --git a/components/cloud_devices/common/cloud_devices_urls.cc b/components/cloud_devices/common/cloud_devices_urls.cc

index b08cc6f087812623a2baff3e1480eecdc2d40073..ee1c2c4d1a1f7210302834f64ec54a78651f8de3 100644

--- a/components/cloud_devices/common/cloud_devices_urls.cc

+++ b/components/cloud_devices/common/cloud_devices_urls.cc

@@ -48,7 +48,7 @@ GURL GetCloudPrintRelativeURL(const std::string& relative_path) {

GURL url = GetCloudPrintURL();

std::string path;

static const char kURLPathSeparator[] = "/";

- base::TrimString(url.path(), kURLPathSeparator, &path);

+ base::TrimString(url.path().as_string(), kURLPathSeparator, &path);

std::string trimmed_path;

base::TrimString(relative_path, kURLPathSeparator, &trimmed_path);

path += kURLPathSeparator;