components/arc/intent_helper/intent_filter.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/intent_helper/intent_filter.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/intent_helper/intent_filter.cc

diff --git a/components/arc/intent_helper/intent_filter.cc b/components/arc/intent_helper/intent_filter.cc

index 7c9db064f5af3bcffb304943fdb4df00799fb989..ba00507eb01a48ea8ec73ac4588ad811a3afd708 100644

--- a/components/arc/intent_helper/intent_filter.cc

+++ b/components/arc/intent_helper/intent_filter.cc

@@ -46,7 +46,7 @@ bool IntentFilter::Match(const GURL& url) const {

// Transcribed from android's IntentFilter#hasDataPath.

bool IntentFilter::HasDataPath(const GURL& url) const {

- const std::string path = url.path();

+ const std::string path = url.path().as_string();

for (const PatternMatcher& pattern : paths_) {

if (pattern.Match(path)) {

return true;