chrome/renderer/searchbox/searchbox.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/searchbox/searchbox.cc

diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc

index 53d21e9ff37d2bbd9734e72f15bc8ead014b075c..baebbea986b8728564387e3cec7502599026efb7 100644

--- a/chrome/renderer/searchbox/searchbox.cc

+++ b/chrome/renderer/searchbox/searchbox.cc

@@ -179,7 +179,7 @@ bool ParseIconRestrictedUrl(const GURL& url,

DCHECK(view_id);

DCHECK(rid);

// Strip leading slash.

- std::string raw_path = url.path();

+ std::string raw_path = url.path().as_string();

DCHECK_GT(raw_path.length(), (size_t) 0);

DCHECK_EQ(raw_path[0], '/');

raw_path = raw_path.substr(1);