chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc

diff --git a/chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc b/chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc

index 1b416f2f5c2594dc07f9de6dad9698bbfef23d6b..735b4dad0d64494b8b95ed0a368209756424e50e 100644

--- a/chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc

+++ b/chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc

@@ -87,7 +87,7 @@ bool PhishingUrlFeatureExtractor::ExtractFeatures(const GURL& url,

}

std::vector<std::string> long_tokens;

- SplitStringIntoLongAlphanumTokens(url.path(), &long_tokens);

+ SplitStringIntoLongAlphanumTokens(url.path().as_string(), &long_tokens);

for (const std::string& token : long_tokens) {

if (!features->AddBooleanFeature(features::kUrlPathToken + token))

return false;