Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc
index 30899a53a8e80f8df22ad8feaa40252a50c1c953..87c82e703fbb28c09ca56f756b1336aff845a034 100644
--- a/chrome/browser/browser_about_handler.cc
+++ b/chrome/browser/browser_about_handler.cc
@@ -67,10 +67,10 @@ bool WillHandleBrowserAboutURL(GURL* url,
// Otherwise, it's handled by the uber settings page.
if (base::FeatureList::IsEnabled(features::kMaterialDesignExtensions)) {
host = chrome::kChromeUIExtensionsHost;
- path = url->path();
+ path = url->path().as_string();
} else {
host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIExtensionsHost + url->path();
+ path = chrome::kChromeUIExtensionsHost + url->path().as_string();
}
// Redirect chrome://settings/extensions (legacy URL).
} else if (host == chrome::kChromeUISettingsHost &&
@@ -89,10 +89,10 @@ bool WillHandleBrowserAboutURL(GURL* url,
// host.
if (MdHistoryUI::IsEnabled(Profile::FromBrowserContext(browser_context))) {
host = chrome::kChromeUIHistoryHost;
- path = url->path();
+ path = url->path().as_string();
} else {
host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIHistoryHost + url->path();
+ path = chrome::kChromeUIHistoryHost + url->path().as_string();
}
#endif
// Redirect chrome://settings, unless MD settings is enabled.
@@ -103,7 +103,7 @@ bool WillHandleBrowserAboutURL(GURL* url,
host = chrome::kChromeUISettingsFrameHost;
} else {
host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUISettingsHost + url->path();
+ path = chrome::kChromeUISettingsHost + url->path().as_string();
}
// Redirect chrome://help, unless MD settings is enabled.
} else if (host == chrome::kChromeUIHelpHost) {
@@ -116,7 +116,7 @@ bool WillHandleBrowserAboutURL(GURL* url,
path = chrome::kChromeUIHelpHost;
} else {
host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIHelpHost + url->path();
+ path = chrome::kChromeUIHelpHost + url->path().as_string();
}
}
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698