[WIP] make GURL::path() return a StringPiece

chrome/browser/browser_about_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_about_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 49 matching lines @@
   // Replace sync with sync-internals (for legacy reasons).
   } else if (host == chrome::kChromeUISyncHost) {
     host = chrome::kChromeUISyncInternalsHost;
   // Redirect chrome://extensions.
 #if defined(ENABLE_EXTENSIONS)
   } else if (host == chrome::kChromeUIExtensionsHost) {
     // If the material design extensions page is enabled, it gets its own host.
     // Otherwise, it's handled by the uber settings page.
     if (base::FeatureList::IsEnabled(features::kMaterialDesignExtensions)) {
       host = chrome::kChromeUIExtensionsHost;
-      path = url->path();
+      path = url->path().as_string();
     } else {
       host = chrome::kChromeUIUberHost;
-      path = chrome::kChromeUIExtensionsHost + url->path();
+      path = chrome::kChromeUIExtensionsHost + url->path().as_string();
     }
   // Redirect chrome://settings/extensions (legacy URL).
   } else if (host == chrome::kChromeUISettingsHost &&
       url->path() == std::string("/") + chrome::kExtensionsSubPage) {
     host = chrome::kChromeUIUberHost;
     path = chrome::kChromeUIExtensionsHost;
 #endif  // defined(ENABLE_EXTENSIONS)
   // Redirect chrome://history.
   } else if (host == chrome::kChromeUIHistoryHost) {
 #if defined(OS_ANDROID)
     // On Android, redirect directly to chrome://history-frame since
     // uber page is unsupported.
     host = chrome::kChromeUIHistoryFrameHost;
 #else
     // Material design history is handled on the top-level chrome://history
     // host.
     if (MdHistoryUI::IsEnabled(Profile::FromBrowserContext(browser_context))) {
       host = chrome::kChromeUIHistoryHost;
-      path = url->path();
+      path = url->path().as_string();
     } else {
       host = chrome::kChromeUIUberHost;
-      path = chrome::kChromeUIHistoryHost + url->path();
+      path = chrome::kChromeUIHistoryHost + url->path().as_string();
     }
 #endif
   // Redirect chrome://settings, unless MD settings is enabled.
   } else if (host == chrome::kChromeUISettingsHost) {
     if (base::FeatureList::IsEnabled(features::kMaterialDesignSettings)) {
       return true;  // Prevent further rewriting - this is a valid URL.
     } else if (::switches::AboutInSettingsEnabled()) {
       host = chrome::kChromeUISettingsFrameHost;
     } else {
       host = chrome::kChromeUIUberHost;
-      path = chrome::kChromeUISettingsHost + url->path();
+      path = chrome::kChromeUISettingsHost + url->path().as_string();
     }
   // Redirect chrome://help, unless MD settings is enabled.
   } else if (host == chrome::kChromeUIHelpHost) {
     if (base::FeatureList::IsEnabled(features::kMaterialDesignSettings)) {
       host = chrome::kChromeUISettingsHost;
       path = chrome::kChromeUIHelpHost;
     } else if (::switches::AboutInSettingsEnabled()) {
       host = chrome::kChromeUISettingsFrameHost;
       if (url->path().empty() || url->path() == "/")
         path = chrome::kChromeUIHelpHost;
     } else {
       host = chrome::kChromeUIUberHost;
-      path = chrome::kChromeUIHelpHost + url->path();
+      path = chrome::kChromeUIHelpHost + url->path().as_string();
     }
   }
 
   GURL::Replacements replacements;
   replacements.SetHostStr(host);
   if (!path.empty())
     replacements.SetPathStr(path);
   *url = url->ReplaceComponents(replacements);
 
   // Having re-written the URL, make the chrome: handler process it.
@@ skipping 10 matching lines @@
         FROM_HERE, base::Bind(&chrome::AttemptRestart));
     return true;
   } else if (base::LowerCaseEqualsASCII(spec, chrome::kChromeUIQuitURL)) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(&chrome::AttemptExit));
     return true;
   }
 
   return false;
 }