Make checked_cast a constexpr

Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast (hence
the need for the NOPRESUBMIT to cover the media directory).

BUG=612995
NOPRESUBMIT=true
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org

Committed: https://crrev.com/00c1837ccba1c6da4cb1e9b26539a6c3801bb2fb
Cr-Commit-Position: refs/heads/master@{#430519}

[jschuh, 2016-11-07 18:59:07]

nit

[jschuh, 2016-11-07 18:59:52]

Patchset #1 (id:1) has been deleted

[jschuh, 2016-11-07 19:01:15]

The CQ bit was checked by jschuh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:02:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 19:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:20:08]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jschuh, 2016-11-07 23:20:17]

compile fix

[jschuh, 2016-11-07 23:23:04]

Description was changed from

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.

BUG=612995
==========

to

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast.

BUG=612995
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org
==========

[jschuh, 2016-11-07 23:23:16]

The CQ bit was checked by jschuh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 23:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:34:01]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jschuh, 2016-11-07 23:40:37]

Description was changed from

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast.

BUG=612995
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org
==========

to

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast (hence
the need for the NOPRESUBMIT to cover the media directory).

BUG=612995
NOPRESUBMIT=true
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org
==========

[jschuh, 2016-11-07 23:40:37]

jschuh@chromium.org changed reviewers:
+ tsepez@chromium.org

[jschuh, 2016-11-07 23:41:13]

compile fix

[jschuh, 2016-11-07 23:42:27]

tsepez - ptal, the only significant change is in safe_conversions.h

[Tom Sepez, 2016-11-07 23:46:56]

lgtm

[Tom Sepez, 2016-11-07 23:48:05]

https://codereview.chromium.org/2481903002/diff/60001/components/autofill/cor...
File components/autofill/core/common/save_password_progress_logger.cc (right):

https://codereview.chromium.org/2481903002/diff/60001/components/autofill/cor...
components/autofill/core/common/save_password_progress_logger.cc:116: int
signed_number = checked_cast<int>(unsigned_number);
nit: local not needed.

[jschuh, 2016-11-08 00:00:58]

nit

[jschuh, 2016-11-08 00:42:03]

The CQ bit was checked by jschuh@chromium.org

[jschuh, 2016-11-08 00:42:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2481903002/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-11-08 00:42:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 02:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 02:44:32]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jschuh, 2016-11-08 02:54:30]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2016-11-08 02:55:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 05:00:01]

Description was changed from

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast (hence
the need for the NOPRESUBMIT to cover the media directory).

BUG=612995
NOPRESUBMIT=true
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org
==========

to

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast (hence
the need for the NOPRESUBMIT to cover the media directory).

BUG=612995
NOPRESUBMIT=true
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org
==========

[commit-bot: I haz the power, 2016-11-08 05:00:02]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-08 05:02:22]

Description was changed from

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast (hence
the need for the NOPRESUBMIT to cover the media directory).

BUG=612995
NOPRESUBMIT=true
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org
==========

to

==========
Make checked_cast a constexpr

Wraps the CHECK in a handler. This makes the non-CHECK case a clean
constexpr, and has the nice effect of throwing a compile error if the
compile-time evaluation can determine that a runtime CHECK would hit.
Also had to fix a few incorrect uses of base::checked_cast (hence
the need for the NOPRESUBMIT to cover the media directory).

BUG=612995
NOPRESUBMIT=true
TBR=vabr@chromium.org,hubbe@chromium.org,dmurph@chromium.org

Committed: https://crrev.com/00c1837ccba1c6da4cb1e9b26539a6c3801bb2fb
Cr-Commit-Position: refs/heads/master@{#430519}
==========

[commit-bot: I haz the power, 2016-11-08 05:02:24]

Patchset 4 (id:??) landed as
https://crrev.com/00c1837ccba1c6da4cb1e9b26539a6c3801bb2fb
Cr-Commit-Position: refs/heads/master@{#430519}