components/autofill/core/common/save_password_progress_logger.cc - Issue 2481903002: Make checked_cast a constexpr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 2481903002: Make checked_cast a constexpr (Closed)

Patch Set: nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 5a5fe7681c2b4ba8c802f8ac84132de4e72996b3..df033c146d6ca1c35762bca371c5a6090a635e41 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -113,8 +113,7 @@ void SavePasswordProgressLogger::LogNumber(

void SavePasswordProgressLogger::LogNumber(

SavePasswordProgressLogger::StringID label,

size_t unsigned_number) {

- int signed_number = checked_cast<int, size_t>(unsigned_number);

- LogNumber(label, signed_number);

+ LogNumber(label, checked_cast<int>(unsigned_number));

}

void SavePasswordProgressLogger::LogMessage(

« no previous file with comments | « base/numerics/safe_numerics_unittest.cc ('k') | media/formats/mp2t/es_parser_h264.cc » ('j') | no next file with comments »