Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2481773002: [Dashboard] Fix regex for complex story names (Closed)

Created:
4 years, 1 month ago by perezju
Modified:
4 years, 1 month ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Dashboard] Fix regex for complex story names Arguments quoting in the command line used for bisect jobs is not interpreted correctly, causing issues in particular with --story-filter argument values with spaces or other special characters in them. To play it safe, while the underlying issue is fixed, we only keep from story names safe characters (alphanumeric ascii) and replace all others with match-any-character regex dots. BUG=chromium:662472 ,catapult:#2967 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b3ab8eaabeea5a812819a8f7b6c08559136f34ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M dashboard/dashboard/start_try_job.py View 1 chunk +5 lines, -3 lines 0 comments Download
M dashboard/dashboard/start_try_job_test.py View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
perezju
Annie, please have a look. This is more like a quick workaround, while I get ...
4 years, 1 month ago (2016-11-07 13:56:37 UTC) #2
sullivan
lgtm Thanks Juan! I'll push this when it lands, let me know if you need ...
4 years, 1 month ago (2016-11-07 14:39:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481773002/1
4 years, 1 month ago (2016-11-07 14:39:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/5060)
4 years, 1 month ago (2016-11-07 14:42:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481773002/1
4 years, 1 month ago (2016-11-07 14:44:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b3ab8eaabeea5a812819a8f7b6c08559136f34ce
4 years, 1 month ago (2016-11-07 14:59:52 UTC) #12
sullivan
This is live on the perf dashboard. Should we re-run bisects blocked on bug 662472?
4 years, 1 month ago (2016-11-07 15:05:30 UTC) #13
perezju
4 years, 1 month ago (2016-11-07 15:41:11 UTC) #14
Message was sent while issue was closed.
On 2016/11/07 15:05:30, sullivan wrote:
> This is live on the perf dashboard. Should we re-run bisects blocked on bug
> 662472?

Yes! Hopefully they should run with no issues now.

Powered by Google App Engine
This is Rietveld 408576698