Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: dashboard/dashboard/start_try_job_test.py

Issue 2481773002: [Dashboard] Fix regex for complex story names (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/start_try_job.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/start_try_job_test.py
diff --git a/dashboard/dashboard/start_try_job_test.py b/dashboard/dashboard/start_try_job_test.py
index 9db00a08c6a9c8d584bc91477ad36b59e691e023..2268410b3d02fe00850f71b63de23b9c5367c58a 100644
--- a/dashboard/dashboard/start_try_job_test.py
+++ b/dashboard/dashboard/start_try_job_test.py
@@ -348,7 +348,8 @@ class StartBisectTest(testing_common.TestCase):
'blog.chromium.org': {},
'dev.chromium.org': {},
'test.blogspot.com': {},
- 'http___test.com_': {}
+ 'http___test.com_': {},
+ 'Wikipedia (1 tab)': {}
},
'vm_final_size_renderer': {
'ref': {},
@@ -369,14 +370,14 @@ class StartBisectTest(testing_common.TestCase):
response = self.testapp.post('/start_try_job', {
'test_path': ('ChromiumPerf/win7/page_cycler.morejs/'
- 'times/http___test.com_'),
+ 'times/Wikipedia (1 tab)'),
'step': 'prefill-info',
})
info = json.loads(response.body)
self.assertEqual('win_perf_bisect', info['bisect_bot'])
self.assertEqual('foo@chromium.org', info['email'])
self.assertEqual('page_cycler.morejs', info['suite'])
- self.assertEqual('times/http___test.com_', info['default_metric'])
+ self.assertEqual('times/Wikipedia (1 tab)', info['default_metric'])
self.assertEqual('ChromiumPerf', info['master'])
self.assertFalse(info['internal_only'])
self.assertTrue(info['use_archive'])
@@ -392,6 +393,7 @@ class StartBisectTest(testing_common.TestCase):
], info['all_bots'])
self.assertEqual(
[
+ 'times/Wikipedia (1 tab)',
'times/blog.chromium.org',
'times/dev.chromium.org',
'times/http___test.com_',
@@ -399,8 +401,7 @@ class StartBisectTest(testing_common.TestCase):
'times/test.blogspot.com'
],
info['all_metrics'])
- # Filter matches story: http://test.com/
- self.assertEqual(info['story_filter'], 'http...test\\.com.')
+ self.assertEqual(info['story_filter'], 'Wikipedia..1.tab.')
response = self.testapp.post('/start_try_job', {
'test_path': ('ChromiumPerf/win7/page_cycler.morejs/'
« no previous file with comments | « dashboard/dashboard/start_try_job.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698