Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2481583003: Send the video surface destruction message on all Android versions (Closed)

Created:
4 years, 1 month ago by watk
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, liberato (no reviews please), mlamouri+watch-media_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send the video surface destruction message on all Android versions We previously only sent this on JB to avoid crashes we saw there. It looks like we're seeing crashes on KK as well, so we have to enable it there too. It will be enabled for M+ soon to implement #setSurface support, so that leaves L as the odd one out. For simplicity we'll just enable it everywhere. BUG=662599 Committed: https://crrev.com/908f0cebd618d41880fdd5f7e7e83e19c39a45c7 Cr-Commit-Position: refs/heads/master@{#430108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M content/browser/media/android/browser_surface_view_manager.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/media/android/browser_surface_view_manager.cc View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
watk
4 years, 1 month ago (2016-11-05 00:11:07 UTC) #2
DaleCurtis
lgtm
4 years, 1 month ago (2016-11-05 00:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481583003/1
4 years, 1 month ago (2016-11-05 00:23:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 01:04:40 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 01:08:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908f0cebd618d41880fdd5f7e7e83e19c39a45c7
Cr-Commit-Position: refs/heads/master@{#430108}

Powered by Google App Engine
This is Rietveld 408576698