Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: content/browser/media/android/browser_surface_view_manager.h

Issue 2481583003: Send the video surface destruction message on all Android versions (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/android/browser_surface_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/android/browser_surface_view_manager.h
diff --git a/content/browser/media/android/browser_surface_view_manager.h b/content/browser/media/android/browser_surface_view_manager.h
index f32f6b888ce3fa241722eedc8a8ab3d33927d0fc..a15e52e398586a0531349f25044d7e4e98c07648 100644
--- a/content/browser/media/android/browser_surface_view_manager.h
+++ b/content/browser/media/android/browser_surface_view_manager.h
@@ -41,10 +41,8 @@ class CONTENT_EXPORT BrowserSurfaceViewManager
// Synchronously notify the decoder that the surface is being destroyed so it
// can stop rendering to it. This sends a message to the GPU process. Without
// this, the MediaCodec decoder will start throwing IllegalStateException, and
- // crash on some devices (http://crbug.com/598408). There is no way for us to
- // make sure the surface outlives the decoder because Android initiates the
- // destruction in some cases.
- void SendDestroyingVideoSurfaceIfRequired(int surface_id);
+ // crash on some devices (http://crbug.com/598408, http://crbug.com/600454).
+ void SendDestroyingVideoSurface(int surface_id);
RenderFrameHost* const render_frame_host_;
« no previous file with comments | « no previous file | content/browser/media/android/browser_surface_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698