Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2481573002: aw: Refactor to move FrameFuture into ChildFrame (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Refactor to move FrameFuture into ChildFrame Instead of have the parallel FrameFuture be held in RenderThreadManager and have the logic for waiting on the frame split between different places. BUG=662096 Committed: https://crrev.com/7b1edda65c774e2a5c4d00016ca426c1086209ff Cr-Commit-Position: refs/heads/master@{#430309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -84 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/browser/child_frame.h View 2 chunks +16 lines, -7 lines 0 comments Download
M android_webview/browser/child_frame.cc View 2 chunks +28 lines, -8 lines 0 comments Download
M android_webview/browser/compositor_frame_consumer.h View 1 chunk +1 line, -4 lines 0 comments Download
M android_webview/browser/hardware_renderer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +1 line, -17 lines 0 comments Download
M android_webview/browser/render_thread_manager.h View 3 chunks +1 line, -7 lines 0 comments Download
M android_webview/browser/render_thread_manager.cc View 2 chunks +3 lines, -33 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
boliu
ptal, this is a pure refactor part 1 of fixing this bug
4 years, 1 month ago (2016-11-05 16:39:45 UTC) #6
boliu
On 2016/11/05 16:39:45, boliu wrote: > ptal, this is a pure refactor > > part ...
4 years, 1 month ago (2016-11-07 16:28:31 UTC) #7
Tobias Sargeant
On 2016/11/07 16:28:31, boliu wrote: > On 2016/11/05 16:39:45, boliu wrote: > > ptal, this ...
4 years, 1 month ago (2016-11-07 16:43:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481573002/1
4 years, 1 month ago (2016-11-07 16:52:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 17:38:44 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 17:44:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b1edda65c774e2a5c4d00016ca426c1086209ff
Cr-Commit-Position: refs/heads/master@{#430309}

Powered by Google App Engine
This is Rietveld 408576698