Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 2481573002: aw: Refactor to move FrameFuture into ChildFrame (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/hardware_renderer.h ('k') | android_webview/browser/render_thread_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/hardware_renderer.cc
diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc
index 391534203dfd68d4ba41527c3b4c8bc62fe09f48..57158635036f0dbf3ba0e23bfb0d617bbc831220 100644
--- a/android_webview/browser/hardware_renderer.cc
+++ b/android_webview/browser/hardware_renderer.cc
@@ -62,30 +62,14 @@ void HardwareRenderer::CommitFrame() {
if (!child_frame.get())
return;
ReturnResourcesInChildFrame();
- frame_future_ = render_thread_manager_->PassFrameFutureOnRT();
child_frame_ = std::move(child_frame);
}
void HardwareRenderer::DrawGL(AwDrawGLInfo* draw_info) {
TRACE_EVENT0("android_webview", "HardwareRenderer::DrawGL");
- if (frame_future_) {
- TRACE_EVENT0("android_webview", "GetFrame");
- DCHECK(child_frame_);
- DCHECK(!child_frame_->frame);
-
- std::unique_ptr<content::SynchronousCompositor::Frame> frame =
- frame_future_->GetFrame();
- if (frame) {
- child_frame_->compositor_frame_sink_id = frame->compositor_frame_sink_id;
- child_frame_->frame = std::move(frame->frame);
- } else {
- child_frame_.reset();
- }
- frame_future_ = nullptr;
- }
-
if (child_frame_) {
+ child_frame_->WaitOnFutureIfNeeded();
last_committed_compositor_frame_sink_id_ =
child_frame_->compositor_frame_sink_id;
}
« no previous file with comments | « android_webview/browser/hardware_renderer.h ('k') | android_webview/browser/render_thread_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698