Issue 2481493002: [Merge M55] [Autofill] Do not show the credit card promo if there are CC suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2481493002: [Merge M55] [Autofill] Do not show the credit card promo if there are CC suggestions. (Closed)

Created:
4 years, 1 month ago by Mathieu

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Merge M55] [Autofill] Do not show the credit card promo if there are CC suggestions. Will now only show the promo if there are no local card suggestions. BUG=626442 TEST=AutofillManager,AutofillExternalDelegate Review-Url: https://codereview.chromium.org/2475663002 Cr-Commit-Position: refs/heads/master@{#429630} (cherry picked from commit f4f3f03b38c8003fa2a9743c73c8104abe563f33) Committed: https://chromium.googlesource.com/chromium/src/+/f133859dc5186e1870863ae540a5abde766ad063

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
	M	components/autofill/core/browser/autofill_external_delegate.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	components/autofill/core/browser/autofill_external_delegate_unittest.cc	View		2 chunks	+7 lines, -11 lines	0 comments	Download

Total messages: 2 (1 generated)

Mathieu

4 years, 1 month ago (2016-11-04 18:27:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f133859dc5186e1870863ae540a5abde766ad063.