Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2475663002: [Autofill] Do not show the credit card promo if there are CC suggestions. (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
Reviewers:
sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Do not show the credit card promo if there are CC suggestions. Will now only show the promo if there are no local card suggestions. BUG=626442 TEST=AutofillManager,AutofillExternalDelegate Committed: https://crrev.com/f4f3f03b38c8003fa2a9743c73c8104abe563f33 Cr-Commit-Position: refs/heads/master@{#429630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Hi Seb, PTAL
4 years, 1 month ago (2016-11-03 15:27:44 UTC) #2
sebsg
lgtm
4 years, 1 month ago (2016-11-03 15:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475663002/1
4 years, 1 month ago (2016-11-03 15:34:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 17:31:24 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:48:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4f3f03b38c8003fa2a9743c73c8104abe563f33
Cr-Commit-Position: refs/heads/master@{#429630}

Powered by Google App Engine
This is Rietveld 408576698