Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2481483002: Mojo C++ bindings: make chrome/browser/ui/webui mojom target use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, dominickn+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: make chrome/browser/ui/webui mojom target use STL types. BUG=624136 Committed: https://crrev.com/6468becd833bfa00794a1cb95ecfdc75ca5c14e9 Cr-Commit-Position: refs/heads/master@{#430042}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -63 lines) Patch
M chrome/browser/ui/webui/engagement/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_page_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc View 1 8 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/plugins/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_handler.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_handler.cc View 1 10 chunks +31 lines, -31 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (13 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks! This CL doesn't get rid of ...
4 years, 1 month ago (2016-11-04 19:01:57 UTC) #5
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-04 20:18:34 UTC) #10
sky
LGTM
4 years, 1 month ago (2016-11-04 22:34:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481483002/40001
4 years, 1 month ago (2016-11-04 22:41:04 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-04 22:46:50 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:48:54 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6468becd833bfa00794a1cb95ecfdc75ca5c14e9
Cr-Commit-Position: refs/heads/master@{#430042}

Powered by Google App Engine
This is Rietveld 408576698