Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2471413004: Remove unnecessary use_new_wrapper_types flag for some mojom targets. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, extensions-reviews_chromium.org, Matt Giuca, toyoshim+midi_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, timvolodine, feature-media-reviews_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, rjkroege, kalyank, riju_, Aaron Boodman, tfarina, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary use_new_wrapper_types flag for some mojom targets. There are three cases: - some targets use use_new_wrapper_types=true which is the default value; - some mojom definitions don't use string/array/map; - some mojom definitions use string/array/map, but they are typemapped. BUG=624136 Committed: https://crrev.com/ff2d879925155958f88e2253de840d6a6908872b Cr-Commit-Position: refs/heads/master@{#429940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M ash/autoclick/mus/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/dom_distiller/content/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/startup_metric_utils/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/battery/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/sensors/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/vibration/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/login/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/session/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/midi/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/background/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/service_manager/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/public/interfaces/gpu/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/public/interfaces/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M ui/app_list/presenter/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/devices/mojo/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-03 23:37:18 UTC) #3
jam
lgtm
4 years, 1 month ago (2016-11-04 00:43:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471413004/1
4 years, 1 month ago (2016-11-04 16:10:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 17:42:13 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:47:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff2d879925155958f88e2253de840d6a6908872b
Cr-Commit-Position: refs/heads/master@{#429940}

Powered by Google App Engine
This is Rietveld 408576698