Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2481343003: Enable downloads UI for NTP-saved pages. (Closed)

Created:
4 years, 1 month ago by dewittj
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Enable downloads UI for NTP-saved pages. This patch fixes 3 problems: * The NTP code is gated on a flag in offline pages that is only for testing. * The NTP namespace is marked as "Supported by Download", which allows the download home to show these pages, and the download notification to work for these pages. BUG=662105 Review-Url: https://codereview.chromium.org/2473953006 Cr-Commit-Position: refs/heads/master@{#429727} (cherry picked from commit b637ece132d7e0a975f0780724f8354297552fcd) Committed: https://chromium.googlesource.com/chromium/src/+/bb84a1f6864dc62f8ed4fe48a64d111c1bbea774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java View 2 chunks +1 line, -3 lines 0 comments Download
M components/offline_pages/client_policy_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/client_policy_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/downloads/download_notifying_observer_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
4 years, 1 month ago (2016-11-07 21:35:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bb84a1f6864dc62f8ed4fe48a64d111c1bbea774 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698