VideoFrame::AllocationSize test against odd values.

VideoFrame::AllocationSize test against odd values.

Skip aligning to even dimensions for various non YUV plannar formats.

BUG=662911
Committed: https://crrev.com/54d98c87e71183a3346d3bbcc1a20b0338af9ffe
Cr-Commit-Position: refs/heads/master@{#430465}

[aleksandar.stojiljkovic, 2016-11-07 20:36:09]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 20:36:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleksandar.stojiljkovic, 2016-11-07 21:46:41]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ dalecurtis@chromium.org

[aleksandar.stojiljkovic, 2016-11-07 21:46:42]

dalecurtis@chromium.org: PTAL.

Thanks.

[DaleCurtis, 2016-11-07 21:53:07]

https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc#n...
media/base/video_frame.cc:526: default:
Should this just list all the other formats to avoid this issue in the future?
We'll get a compiler error for new ones then.

[commit-bot: I haz the power, 2016-11-07 22:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 22:17:10]

Dry run: This issue passed the CQ dry run.

[aleksandar.stojiljkovic, 2016-11-07 22:27:25]

Patch Set 2 : #5 fix. Thanks DaleCurtis@.

https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc#n...
media/base/video_frame.cc:526: default:
On 2016/11/07 21:53:06, DaleCurtis wrote:
> Should this just list all the other formats to avoid this issue in the future?
> We'll get a compiler error for new ones then.

Done.

[DaleCurtis, 2016-11-07 22:29:28]

lgtm

[DaleCurtis, 2016-11-07 22:29:58]

one nit

https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame....
media/base/video_frame.cc:131: return 0;
return false?

[aleksandar.stojiljkovic, 2016-11-07 22:38:00]

Patch Set 3 : #10 fix. Thanks DaleCurtis@.

https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame....
media/base/video_frame.cc:131: return 0;
On 2016/11/07 22:29:58, DaleCurtis wrote:
> return false?

Thanks. Done.

[aleksandar.stojiljkovic, 2016-11-07 22:38:14]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com

[aleksandar.stojiljkovic, 2016-11-07 22:38:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2481343002/#ps40001
(title: "#10 fix. Thanks DaleCurtis@.")

[commit-bot: I haz the power, 2016-11-07 22:38:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:29:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 01:38:01]

Description was changed from

==========
VideoFrame::AllocationSize test against odd values.

Skip aligning to even dimensions for various non YUV plannar formats.

BUG=662911
==========

to

==========
VideoFrame::AllocationSize test against odd values.

Skip aligning to even dimensions for various non YUV plannar formats.

BUG=662911

Committed: https://crrev.com/54d98c87e71183a3346d3bbcc1a20b0338af9ffe
Cr-Commit-Position: refs/heads/master@{#430465}
==========

[commit-bot: I haz the power, 2016-11-08 01:38:02]

Patchset 3 (id:??) landed as
https://crrev.com/54d98c87e71183a3346d3bbcc1a20b0338af9ffe
Cr-Commit-Position: refs/heads/master@{#430465}