Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2481343002: VideoFrame::AllocationSize test against odd values. (Closed)

Created:
4 years, 1 month ago by aleksandar.stojiljkovic
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoFrame::AllocationSize test against odd values. Skip aligning to even dimensions for various non YUV plannar formats. BUG=662911 Committed: https://crrev.com/54d98c87e71183a3346d3bbcc1a20b0338af9ffe Cr-Commit-Position: refs/heads/master@{#430465}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #5 fix. Thanks DaleCurtis@. #

Total comments: 2

Patch Set 3 : #10 fix. Thanks DaleCurtis@. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1 line) Patch
M media/base/video_frame.cc View 1 2 2 chunks +40 lines, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
aleksandar.stojiljkovic
dalecurtis@chromium.org: PTAL. Thanks.
4 years, 1 month ago (2016-11-07 21:46:42 UTC) #4
DaleCurtis
https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc File media/base/video_frame.cc (right): https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc#newcode526 media/base/video_frame.cc:526: default: Should this just list all the other formats ...
4 years, 1 month ago (2016-11-07 21:53:07 UTC) #5
aleksandar.stojiljkovic
Patch Set 2 : #5 fix. Thanks DaleCurtis@. https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc File media/base/video_frame.cc (right): https://codereview.chromium.org/2481343002/diff/1/media/base/video_frame.cc#newcode526 media/base/video_frame.cc:526: default: ...
4 years, 1 month ago (2016-11-07 22:27:25 UTC) #8
DaleCurtis
lgtm
4 years, 1 month ago (2016-11-07 22:29:28 UTC) #9
DaleCurtis
one nit https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame.cc File media/base/video_frame.cc (right): https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame.cc#newcode131 media/base/video_frame.cc:131: return 0; return false?
4 years, 1 month ago (2016-11-07 22:29:58 UTC) #10
aleksandar.stojiljkovic
Patch Set 3 : #10 fix. Thanks DaleCurtis@. https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame.cc File media/base/video_frame.cc (right): https://codereview.chromium.org/2481343002/diff/20001/media/base/video_frame.cc#newcode131 media/base/video_frame.cc:131: return ...
4 years, 1 month ago (2016-11-07 22:38:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481343002/40001
4 years, 1 month ago (2016-11-07 22:38:42 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 01:29:50 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 01:38:02 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/54d98c87e71183a3346d3bbcc1a20b0338af9ffe
Cr-Commit-Position: refs/heads/master@{#430465}

Powered by Google App Engine
This is Rietveld 408576698