VideoFrame::AllocationSize test against odd values.

media/base/video_frame.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/video_frame.h"
 
 #include <algorithm>
 #include <climits>
 
 #include "base/atomic_sequence_num.h"
@@ skipping 497 matching lines @@
 }
 
 // static
 gfx::Size VideoFrame::PlaneSize(VideoPixelFormat format,
                                 size_t plane,
                                 const gfx::Size& coded_size) {
   DCHECK(IsValidPlane(plane, format));
 
   int width = coded_size.width();
   int height = coded_size.height();
-  if (format != PIXEL_FORMAT_ARGB) {
-    // Align to multiple-of-two size overall. This ensures that non-subsampled
-    // planes can be addressed by pixel with the same scaling as the subsampled
-    // planes.
-    width = RoundUp(width, 2);
-    height = RoundUp(height, 2);
+  switch (format) {
+    case PIXEL_FORMAT_ARGB:
+    case PIXEL_FORMAT_XRGB:
+    case PIXEL_FORMAT_RGB24:
+    case PIXEL_FORMAT_RGB32:
+    case PIXEL_FORMAT_Y8:
+    case PIXEL_FORMAT_Y16:
+      break;
+    default:

[DaleCurtis, 2016/11/07 21:53:06]

Should this just list all the other formats to avoid this issue in the future?
We'll get a compiler error for new ones then.

[aleksandar.stojiljkovic, 2016/11/07 22:27:25]

Done.

+      // Align to multiple-of-two size overall. This ensures that non-subsampled
+      // planes can be addressed by pixel with the same scaling as the
+      // subsampled planes.
+      width = RoundUp(width, 2);
+      height = RoundUp(height, 2);
+      break;
   }
 
   const gfx::Size subsample = SampleSize(format, plane);
   DCHECK(width % subsample.width() == 0);
   DCHECK(height % subsample.height() == 0);
   return gfx::Size(BytesPerElement(format, plane) * width / subsample.width(),
                    height / subsample.height());
 }
 
 // static
@@ skipping 575 matching lines @@
   if (zero_initialize_memory)
     memset(data, 0, data_size);
 
   for (size_t plane = 0; plane < NumPlanes(format_); ++plane)
     data_[plane] = data + offset[plane];
 
   AddDestructionObserver(base::Bind(&base::AlignedFree, data));
 }
 
 }  // namespace media