Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2481173002: Ensure that navigation will proceed when no NavigationHandle is found (Closed)

Created:
4 years, 1 month ago by clamy
Modified:
4 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that navigation will proceed when no NavigationHandle is found This is a fix for an issue where the NavigationHandle is destroyed by the commit of a same-page navigation, which will cancel an ongoing navigation. This patch allows the navigation to go through, and is meant to be a temporary fix until https://codereview.chromium.org/2475693002/ lands. BUG=658530 Committed: https://crrev.com/13dbcd1e7b46a500c1afde8256949aeecdcb18be Cr-Commit-Position: refs/heads/master@{#430650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/loader/navigation_resource_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
clamy
@nasko: PTAL My goal is to land this and merge to M55 to fix the ...
4 years, 1 month ago (2016-11-07 12:30:14 UTC) #5
nasko
LGTM
4 years, 1 month ago (2016-11-08 16:47:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481173002/1
4 years, 1 month ago (2016-11-08 16:48:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 18:06:40 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 18:38:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13dbcd1e7b46a500c1afde8256949aeecdcb18be
Cr-Commit-Position: refs/heads/master@{#430650}

Powered by Google App Engine
This is Rietveld 408576698