Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2481083003: Make `Stream.take(0)` still listen and close the stream. (Closed)

Created:
4 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
4 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make `Stream.take(0)` still listen and close the stream. It shouldn't matter, but for some streams (e.g., a `ReceivePort`) it does make a big difference whether it's closed or not. We can't make a port not keep the isolate alive unless it has been listened to. If we could, this wouldn't be necessary. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/88ef4e98fa89a077bf5b3664e88aa7a55d8fdad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sdk/lib/async/stream_pipe.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-11-07 15:47:25 UTC) #2
floitsch
LGTM.
4 years, 1 month ago (2016-11-07 15:49:17 UTC) #3
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-11-07 16:01:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88ef4e98fa89a077bf5b3664e88aa7a55d8fdad7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698