sdk/lib/async/stream_pipe.dart - Issue 2481083003: Make `Stream.take(0)` still listen and close the stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream_pipe.dart

Issue 2481083003: Make `Stream.take(0)` still listen and close the stream. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/async/stream_pipe.dart

diff --git a/sdk/lib/async/stream_pipe.dart b/sdk/lib/async/stream_pipe.dart

index 58acd4f8b47b23e5fdfbf55e2038515452bf9564..643d14227afca6b41cda51b7ede42bbf8ae8b465 100644

--- a/sdk/lib/async/stream_pipe.dart

+++ b/sdk/lib/async/stream_pipe.dart

@@ -327,6 +327,7 @@ class _TakeStream<T> extends _ForwardingStream<T, T> {

void onDone(),

bool cancelOnError) {

if (_count == 0) {

+ _source.listen(null).cancel();

return new _DoneStreamSubscription<T>(onDone);

}

return new _StateStreamSubscription<T>(

« no previous file with comments | « no previous file | no next file » | no next file with comments »