Add a page to explain earcons in the tutorial

Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural containers (which have side effects)

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/907e5f75ac06f2921c231e488e249e7d42b21115
Cr-Commit-Position: refs/heads/master@{#432261}

[David Tseng, 2016-11-11 18:26:07]

Description was changed from

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=
==========

to

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-11 18:26:49]

Description was changed from

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=613176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-11 18:26:49]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-11 18:27:50]

Description was changed from

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=613176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-11 22:13:14]

Description was changed from

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)
- change the learn mode key bindings to Search+O+L

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-11-12 00:03:59]

lgtm

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:41:
chrome.extension.getBackgroundPage()['cvox']['ChromeVox'][
note: at some point we should probably come up with an abstract interface for
the background page
so this is typesafe

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:42:
'earcons']['cancelEarcon'](prevEarcon);
nit: indent by 4

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:45:
'earcons']['playEarcon'](earcon);
nit: indent by 4

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(right):

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2636:
<message desc="Describes an audio clip that gets played for a specific event or
control type. Use the default string as a guide to what the audio clip
represents or conveys." name="IDS_CHROMEVOX_alert_modal_earcon_description">
The name should be all caps, fix throughout

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2655:
An invalid key press
Note that we use the same sound for invalid key press, and wrap.

Perhaps we should either make them distinct, like changing the pitch of one
would be easy, or change the descriptions

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2673:
Movement from beginning to end or end to beginning inside of a page, dialog, or
other container
I think it's fine to use the word "wrap", as in "Wrapping from beginning to end"
or so on

[David Tseng, 2016-11-13 07:32:57]

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:41:
chrome.extension.getBackgroundPage()['cvox']['ChromeVox'][
On 2016/11/12 00:03:59, dmazzoni wrote:
> note: at some point we should probably come up with an abstract interface for
> the background page
> so this is typesafe

Acknowledged.

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:42:
'earcons']['cancelEarcon'](prevEarcon);
On 2016/11/12 00:03:59, dmazzoni wrote:
> nit: indent by 4

Done.

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:45:
'earcons']['playEarcon'](earcon);
On 2016/11/12 00:03:59, dmazzoni wrote:
> nit: indent by 4

Done.

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(right):

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2636:
<message desc="Describes an audio clip that gets played for a specific event or
control type. Use the default string as a guide to what the audio clip
represents or conveys." name="IDS_CHROMEVOX_alert_modal_earcon_description">
On 2016/11/12 00:03:59, dmazzoni wrote:
> The name should be all caps, fix throughout

Done.

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2655:
An invalid key press
On 2016/11/12 00:03:59, dmazzoni wrote:
> Note that we use the same sound for invalid key press, and wrap.
> 
> Perhaps we should either make them distinct, like changing the pitch of one
> would be easy, or change the descriptions

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=664779 and assigned
to you.

This earcon isn't currently used, so it doesn't really matter I guess. It is
helpful though so perhaps in phase4 we'll add it for unrecognized commands;
let's go with changing the sound.

https://codereview.chromium.org/2481013011/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2673:
Movement from beginning to end or end to beginning inside of a page, dialog, or
other container
On 2016/11/12 00:03:59, dmazzoni wrote:
> I think it's fine to use the word "wrap", as in "Wrapping from beginning to
end"
> or so on

No strong opinion here, so done.

[David Tseng, 2016-11-13 07:33:39]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-13 07:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2481013011/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-11-13 07:33:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-13 08:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-13 08:17:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-11-15 20:28:12]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-15 20:28:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2481013011/#ps60001
(title: "Yay; tests caught regression!")

[commit-bot: I haz the power, 2016-11-15 20:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:43:54]

Description was changed from

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-15 21:43:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-15 21:47:35]

Description was changed from

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a page to explain earcons in the tutorial

- partially revert focusing behavior to focus everything except for structural
containers (which have side effects)

BUG=613176
TEST=tab and search+left/right through the earcon page. Verify earcons play and
speech/braille output.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/907e5f75ac06f2921c231e488e249e7d42b21115
Cr-Commit-Position: refs/heads/master@{#432261}
==========

[commit-bot: I haz the power, 2016-11-15 21:47:36]

Patchset 4 (id:??) landed as
https://crrev.com/907e5f75ac06f2921c231e488e249e7d42b21115
Cr-Commit-Position: refs/heads/master@{#432261}