Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3299)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2481013011: Add a page to explain earcons in the tutorial (Closed)
Patch Set: Yay; tests caught regression! Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index dc2fdece34394575665044b27b4eea25786baba3..b120e2abcbfc4705f984b0665212a5f11b26d59e 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -786,11 +786,13 @@ Background.prototype = {
}
// Next, try to focus the start or end node.
- if (isFocusableLinkOrControl(start)) {
+ if (!AutomationPredicate.structuralContainer(start) &&
+ start.state.focusable) {
if (!start.state.focused)
start.focus();
return;
- } else if (isFocusableLinkOrControl(end)) {
+ } else if (!AutomationPredicate.structuralContainer(end) &&
+ end.state.focusable) {
if (!end.state.focused)
end.focus();
return;
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698