Improve tracking of user initiated page loads.

chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 06beda69a78a05cc10b8b946f221efe066c9d09d..2ee87596a4c4e341013dbdebc00d5a9dea92ebbe 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -65,15 +65,19 @@ const char kHistogramAbortForwardBackUserInitiated[] =
     "PageLoad.AbortTiming.ForwardBackNavigation.BeforeCommit.UserInitiated";
 const char kHistogramAbortReloadUserInitiated[] =
     "PageLoad.AbortTiming.Reload.BeforeCommit.UserInitiated";
+const char kHistogramAbortStopUserInitiated[] =
+    "PageLoad.AbortTiming.Stop.BeforeCommit.UserInitiated";
+const char kHistogramAbortCloseUserInitiated[] =
+    "PageLoad.AbortTiming.Close.BeforeCommit.UserInitiated";
+const char kHistogramAbortBackgroundUserInitiated[] =
+    "PageLoad.AbortTiming.Background.BeforeCommit.UserInitiated";
+const char kHistogramAbortOtherUserInitiated[] =
+    "PageLoad.AbortTiming.Other.BeforeCommit.UserInitiated";
 
 }  // namespace internal
 
 namespace {
 
-bool IsAbortUserInitiated(const page_load_metrics::PageLoadExtraInfo& info) {
-  return info.abort_user_initiated && info.user_gesture;
-}
-
 void RecordAbortBeforeCommit(UserAbortType abort_type,
                              bool user_initiated,
                              base::TimeDelta time_to_abort) {
@@ -109,18 +113,34 @@ void RecordAbortBeforeCommit(UserAbortType abort_type,
     case UserAbortType::ABORT_STOP:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortStopBeforeCommit,
                           time_to_abort);
+      if (user_initiated) {
+        PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortStopUserInitiated,
+                            time_to_abort);
+      }
       return;
     case UserAbortType::ABORT_CLOSE:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforeCommit,
                           time_to_abort);
+      if (user_initiated) {
+        PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseUserInitiated,
+                            time_to_abort);
+      }
       return;
     case UserAbortType::ABORT_BACKGROUND:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortBackgroundBeforeCommit,
                           time_to_abort);
+      if (user_initiated) {
+        PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortBackgroundUserInitiated,
+                            time_to_abort);
+      }
       return;
     case UserAbortType::ABORT_OTHER:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortOtherBeforeCommit,
                           time_to_abort);
+      if (user_initiated) {
+        PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortOtherUserInitiated,
+                            time_to_abort);
+      }
       return;
     case UserAbortType::ABORT_NONE:
     case UserAbortType::ABORT_LAST_ENTRY:
@@ -267,6 +287,6 @@ void AbortsPageLoadMetricsObserver::OnFailedProvisionalLoad(
     return;
 
   RecordAbortBeforeCommit(extra_info.abort_type,
-                          IsAbortUserInitiated(extra_info),
+                          extra_info.abort_user_initiated,

[Bryan McQuade, 2016/11/10 15:51:22]

earlier, I noted that when deciding if the abort was user initiated, we should
probably not also look at whether the nav being aborted was user initiated. thus
the logic in IsAbortUserInitiated simplifies to checking this boolean, so I
removed the function and inlined the logic.

                           extra_info.time_to_abort.value());
 }