chrome/browser/page_load_metrics/metrics_web_contents_observer.cc - Issue 2481013007: Improve tracking of user initiated page loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2481013007: Improve tracking of user initiated page loads. (Closed)

Patch Set: revert broken logic Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

index 995e15df632fbefd83c17fd65937557fadf22bcb..ccff33a0de4755db22a356bb8e207754217eebf3 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

@@ -250,7 +250,7 @@ void MetricsWebContentsObserver::HandleFailedNavigationForTrackedLoad(

void MetricsWebContentsObserver::HandleCommittedNavigationForTrackedLoad(

content::NavigationHandle* navigation_handle,

std::unique_ptr<PageLoadTracker> tracker) {

- if (!navigation_handle->HasUserGesture() &&

+ if (!IsNavigationUserInitiated(navigation_handle) &&

(navigation_handle->GetPageTransition() &

ui::PAGE_TRANSITION_CLIENT_REDIRECT) != 0 &&

committed_load_)