Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2481013007: Improve tracking of user initiated page loads. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index fd8c8ffb16affce1d782c637335698ae6a6430fd..e0480c29d73ba21ea6b4490a74da31e357c69a63 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -70,7 +70,7 @@ struct PageLoadExtraInfo {
const base::Optional<base::TimeDelta>& first_background_time,
const base::Optional<base::TimeDelta>& first_foreground_time,
bool started_in_foreground,
- bool user_gesture,
+ bool user_initiated,
const GURL& committed_url,
const GURL& start_url,
UserAbortType abort_type,
@@ -95,7 +95,7 @@ struct PageLoadExtraInfo {
// True if this is either a browser initiated navigation or the user_gesture
// bit is true in the renderer.
- const bool user_gesture;
+ const bool user_initiated;
// Committed URL. If the page load did not commit, |committed_url| will be
// empty.
@@ -108,6 +108,15 @@ struct PageLoadExtraInfo {
// aborted, |abort_type| will be |ABORT_NONE|.
const UserAbortType abort_type;
+ // Whether the abort for this page load was user initiated. For example, if
+ // this page load was aborted by a new navigation, this field tracks whether
+ // that new navigation was user-initiated. This field is only useful if this
+ // page load's abort type is a value other than ABORT_NONE. Note that this
+ // value is currently experimental, and is subject to change. In particular,
+ // this field is never set to true for some abort types, such as stop and
+ // close, since we don't yet have sufficient instrumentation to know if a stop
+ // or close was caused by a user action.
+ //
// TODO(csharrison): If more metadata for aborts is needed we should provide a
// better abstraction. Note that this is an approximation.
bool abort_user_initiated;

Powered by Google App Engine
This is Rietveld 408576698