Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4682)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2481013007: Improve tracking of user initiated page loads. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 5c0d8a07fd842e80d6f16fb3970abb6f3d4b224e..98b46899a0d8fe5feb3ffa75c4fad1f293efff0e 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -199,7 +199,6 @@ const char kHistogramFirstScrollInputAfterFirstPaint[] =
CorePageLoadMetricsObserver::CorePageLoadMetricsObserver()
: transition_(ui::PAGE_TRANSITION_LINK),
- initiated_by_user_gesture_(false),
was_no_store_main_resource_(false) {}
CorePageLoadMetricsObserver::~CorePageLoadMetricsObserver() {}
@@ -208,7 +207,6 @@ page_load_metrics::PageLoadMetricsObserver::ObservePolicy
CorePageLoadMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
transition_ = navigation_handle->GetPageTransition();
- initiated_by_user_gesture_ = navigation_handle->HasUserGesture();
navigation_start_ = navigation_handle->NavigationStart();
const net::HttpResponseHeaders* headers =
navigation_handle->GetResponseHeaders();
@@ -327,7 +325,7 @@ void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
timing.first_contentful_paint.value());
}
- if (info.user_gesture) {
+ if (info.user_initiated) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintUserInitiated,
timing.first_contentful_paint.value());
}
@@ -337,7 +335,7 @@ void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
PAGE_LOAD_HISTOGRAM(
internal::kHistogramLoadTypeFirstContentfulPaintReload,
timing.first_contentful_paint.value());
- if (initiated_by_user_gesture_) {
+ if (info.user_initiated) {
PAGE_LOAD_HISTOGRAM(
internal::kHistogramLoadTypeFirstContentfulPaintReloadByGesture,
timing.first_contentful_paint.value());

Powered by Google App Engine
This is Rietveld 408576698