 Chromium Code Reviews
 Chromium Code Reviews Issue 2481013007:
  Improve tracking of user initiated page loads.  (Closed)
    
  
    Issue 2481013007:
  Improve tracking of user initiated page loads.  (Closed) 
  | Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h | 
| diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h | 
| index fd8c8ffb16affce1d782c637335698ae6a6430fd..2df853b476e72dcc14305f8016d6ed76d95b5b56 100644 | 
| --- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h | 
| +++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h | 
| @@ -70,7 +70,7 @@ struct PageLoadExtraInfo { | 
| const base::Optional<base::TimeDelta>& first_background_time, | 
| const base::Optional<base::TimeDelta>& first_foreground_time, | 
| bool started_in_foreground, | 
| - bool user_gesture, | 
| + bool user_initiated, | 
| const GURL& committed_url, | 
| const GURL& start_url, | 
| UserAbortType abort_type, | 
| @@ -95,7 +95,7 @@ struct PageLoadExtraInfo { | 
| // True if this is either a browser initiated navigation or the user_gesture | 
| // bit is true in the renderer. | 
| - const bool user_gesture; | 
| + const bool user_initiated; | 
| // Committed URL. If the page load did not commit, |committed_url| will be | 
| // empty. | 
| @@ -108,6 +108,7 @@ struct PageLoadExtraInfo { | 
| // aborted, |abort_type| will be |ABORT_NONE|. | 
| const UserAbortType abort_type; | 
| + // Whether the page load that aborted this page load was user initiated. | 
| 
Charlie Harrison
2016/11/10 22:26:05
nit: Can this comment be more general too?
 
Bryan McQuade
2016/11/10 22:52:50
Sure, I duped the other comment.
 | 
| // TODO(csharrison): If more metadata for aborts is needed we should provide a | 
| // better abstraction. Note that this is an approximation. | 
| bool abort_user_initiated; |