Improve tracking of user initiated page loads.

chrome/browser/page_load_metrics/page_load_metrics_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_
 
 #include "base/macros.h"
 #include "base/optional.h"
 #include "chrome/common/page_load_metrics/page_load_timing.h"
@@ skipping 52 matching lines @@
 
   base::TimeDelta time_to_failed_provisional_load;
   net::Error error;
 };
 
 struct PageLoadExtraInfo {
   PageLoadExtraInfo(
       const base::Optional<base::TimeDelta>& first_background_time,
       const base::Optional<base::TimeDelta>& first_foreground_time,
       bool started_in_foreground,
-      bool user_gesture,
+      bool user_initiated,
       const GURL& committed_url,
       const GURL& start_url,
       UserAbortType abort_type,
       bool abort_user_initiated,
       const base::Optional<base::TimeDelta>& time_to_abort,
       int num_cache_requests,
       int num_network_requests,
       const PageLoadMetadata& metadata);
 
   PageLoadExtraInfo(const PageLoadExtraInfo& other);
 
   ~PageLoadExtraInfo();
 
   // The first time that the page was backgrounded since the navigation started.
   const base::Optional<base::TimeDelta> first_background_time;
 
   // The first time that the page was foregrounded since the navigation started.
   const base::Optional<base::TimeDelta> first_foreground_time;
 
   // True if the page load started in the foreground.
   const bool started_in_foreground;
 
   // True if this is either a browser initiated navigation or the user_gesture
   // bit is true in the renderer.
-  const bool user_gesture;
+  const bool user_initiated;
 
   // Committed URL. If the page load did not commit, |committed_url| will be
   // empty.
   const GURL committed_url;
 
   // The URL that started the navigation, before redirects.
   const GURL start_url;
 
   // The abort time and time to abort for this page load. If the page was not
   // aborted, |abort_type| will be |ABORT_NONE|.
   const UserAbortType abort_type;
 
+  // Whether the page load that aborted this page load was user initiated.

[Charlie Harrison, 2016/11/10 22:26:05]

nit: Can this comment be more general too?

[Bryan McQuade, 2016/11/10 22:52:50]

Sure, I duped the other comment.

   // TODO(csharrison): If more metadata for aborts is needed we should provide a
   // better abstraction. Note that this is an approximation.
   bool abort_user_initiated;
 
   const base::Optional<base::TimeDelta> time_to_abort;
 
   // Note: these are only approximations, based on WebContents attribution from
   // ResourceRequestInfo objects while this is the currently committed load in
   // the WebContents.
   int num_cache_requests;
@@ skipping 140 matching lines @@
   // OnFailedProvisionalLoad is invoked for tracked page loads that did not
   // commit, immediately before the observer is deleted.
   virtual void OnFailedProvisionalLoad(
       const FailedProvisionalLoadInfo& failed_provisional_load_info,
       const PageLoadExtraInfo& extra_info) {}
 };
 
 }  // namespace page_load_metrics
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_