Fix a variety of panel issues

Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of the set of pages
3. the title wasn't being announced, so users don't actually know anything happened when they moved in either direction. Make the heading focused when we generate the page
4. the page for command menus asks users to press search plus period. This exits the tutorial entirely and coming back jumps back to the beginning. Save the current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df
Cr-Commit-Position: refs/heads/master@{#430373}

[David Tseng, 2016-11-04 22:32:34]

Description was changed from

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=
==========

to

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-04 22:33:46]

Description was changed from

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-04 22:33:46]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-07 00:09:39]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 00:09:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 01:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 01:15:01]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-11-07 07:46:01]

lgtm

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:580:
"command": "help",
Should this be "tutorial"?

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:589:
"command": "showNextUpdatePage",
Doesn't showNextUpdatePage show the tutorial? Maybe it shoudln't

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
(right):

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js:184:
case 'showNextUpdatePage':
Should we have two commands that do the same thing?

Do you want a special landing page in the tutorial for transitioning from
Classic to Next? That wouldn't be hard

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:128:
element.setAttribute('tabindex', -1);
Let's add a css rule so this doesn't show a focus ring visually: h2:focus {
outline: none; }

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:145:
$('tutorial_next').setAttribute('aria-disabled', disableNext);
Do this with the regular disabled attribute rather than aria-disabled

[David Tseng, 2016-11-07 19:43:29]

Added update notes and extended your layout builder. Also made blur only trigger
close path when the active element is not body since tabbing off the last
contorl actually fires blur on body and exits the little aura window into the
foregrounded tab.

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:580:
"command": "help",
On 2016/11/07 07:46:01, dmazzoni wrote:
> Should this be "tutorial"?

No, because it matches the command name from classic. We haven't changed command
names before (e.g. nextObject).

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:589:
"command": "showNextUpdatePage",
On 2016/11/07 07:46:01, dmazzoni wrote:
> Doesn't showNextUpdatePage show the tutorial? Maybe it shoudln't

When I added this, it pointed to a dummy landing page, then you added the
tutorial but we never changed this command.

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
(right):

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js:184:
case 'showNextUpdatePage':
On 2016/11/07 07:46:01, dmazzoni wrote:
> Should we have two commands that do the same thing?
> 
> Do you want a special landing page in the tutorial for transitioning from
> Classic to Next? That wouldn't be hard

Done.

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:128:
element.setAttribute('tabindex', -1);
On 2016/11/07 07:46:01, dmazzoni wrote:
> Let's add a css rule so this doesn't show a focus ring visually: h2:focus {
> outline: none; }

Done.

https://codereview.chromium.org/2480913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:145:
$('tutorial_next').setAttribute('aria-disabled', disableNext);
On 2016/11/07 07:46:01, dmazzoni wrote:
> Do this with the regular disabled attribute rather than aria-disabled

I totally would, ecept for
crbug.com/662974
which I ran into while doing exactly that.

You can't actually even do both because setting foo.disabled = true actually
clears the ax.state.disabled flag...so, leaving as is.

[David Tseng, 2016-11-07 19:55:00]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:55:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-11-07 19:58:34]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-07 19:58:35]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-11-07 20:00:30]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-07 20:00:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2480913002/#ps40001
(title: "Fix bad js annotation, indent, finalizeDom_, etc.")

[commit-bot: I haz the power, 2016-11-07 20:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 20:59:43]

Description was changed from

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-07 20:59:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-07 21:19:08]

Description was changed from

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing
away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of
the set of pages
3. the title wasn't being announced, so users don't actually know anything
happened when they moved in either direction. Make the heading focused when we
generate the page
4. the page for command menus asks users to press search plus period. This exits
the tutorial entirely and coming back jumps back to the beginning. Save the
current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df
Cr-Commit-Position: refs/heads/master@{#430373}
==========

[commit-bot: I haz the power, 2016-11-07 21:19:09]

Patchset 3 (id:??) landed as
https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df
Cr-Commit-Position: refs/heads/master@{#430373}

[dmazzoni, 2016-11-08 00:55:15]

lgtm

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:103:
this.showPage_([
Maybe make this a constant at the top like Tutorial.PAGES - call it
Tutorial.UPDATE_NOTES_PAGE

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:198:
$('tutorial_next').setAttribute('aria-disabled', disableNext);
Can you do both disabled and aria-disabled? Disabled will do the right thing in
terms of focusability and the visual styling, and aria-disabled is just a
temporary hack until we fix the underlying bug

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(right):

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2586:
We've been hard at work on a new and improved ChromeVox experience; here's
what's new
End with a period

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2589:
new key bindings. We've made Search the ChromeVox modifier and dramatically
simplified the key combinations.
Start with a capital

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2592:
new earcons. We've refreshed the set of audio icons you hear to make browsing
more responsive.
Start with a capital

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2595:
under the hood upgrades. We've revamped how ChromeVox works from the bottom up.
Expect better performance, stability, and web support/compliance.
Start with a capital

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2598:
We're excited to hear from you on this new experience. Send us feedback directly
by pressing Search+a, then i. Press the next button to continue onto the
tutorial to learn everything you need to get started.
...or how to exit / escape if you're already a ChromeVox Next user?

[David Tseng, 2016-11-08 01:20:28]

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2480913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:198:
$('tutorial_next').setAttribute('aria-disabled', disableNext);
On 2016/11/08 00:55:15, dmazzoni wrote:
> Can you do both disabled and aria-disabled? Disabled will do the right thing
in
> terms of focusability and the visual styling, and aria-disabled is just a
> temporary hack until we fix the underlying bug

Yeah I tried that too.

No unfortunately that actually appears to undo the aria disabled. In other
words,  setting both to true actually results in axobj disabled being undefined.
Blink issues all around.