Fix links in tutorial

Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're also treating the webView like a structural container (i.e. we automatically navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59
Cr-Commit-Position: refs/heads/master@{#430512}

[David Tseng, 2016-11-07 20:36:43]

Description was changed from

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=
==========

to

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-07 20:37:07]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-07 22:02:46]

Description was changed from

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-11-07 23:55:35]

lgtm

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(left):

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:181:
element.href = pageElement.link;
I think you should add href='#' or role="link" and tabIndex=0, because otherwise
technically an "a" element with no href isn't even a link

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:181:
element.onclick = function() {
return false, or stopPropagation/preventDefault?

[David Tseng, 2016-11-08 02:46:00]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-08 02:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2480303003/#ps40001
(title: "Misc fixes")

[commit-bot: I haz the power, 2016-11-08 02:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-11-08 02:47:24]

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(left):

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:181:
element.href = pageElement.link;
On 2016/11/07 23:55:35, dmazzoni wrote:
> I think you should add href='#' or role="link" and tabIndex=0, because
otherwise
> technically an "a" element with no href isn't even a link

Strange it worked for me as I definitely moved to the links via search+l in
order to verify that they did indeed respond to click.

Anyway, converted to role link with tabindex 0 and new-style event listeners.

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
(right):

https://codereview.chromium.org/2480303003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js:181:
element.onclick = function() {
On 2016/11/07 23:55:35, dmazzoni wrote:
> return false, or stopPropagation/preventDefault?

Ok, explicitly returning false

[David Tseng, 2016-11-08 02:52:39]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-11-08 02:59:26]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-08 02:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2480303003/#ps60001
(title: "Fix links in tutorial")

[commit-bot: I haz the power, 2016-11-08 03:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:59:45]

Description was changed from

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-08 03:59:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-08 04:05:05]

Description was changed from

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens
via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're
also treating the webView like a structural container (i.e. we automatically
navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG=638696
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59
Cr-Commit-Position: refs/heads/master@{#430512}
==========

[commit-bot: I haz the power, 2016-11-08 04:05:07]

Patchset 4 (id:??) landed as
https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59
Cr-Commit-Position: refs/heads/master@{#430512}