Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2480843002: Support for Quick Assists with the new analysis driver. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -13 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +34 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +48 lines, -13 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 1 month ago (2016-11-04 20:23:06 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2480843002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart File pkg/analysis_server/lib/src/edit/edit_domain.dart (right): https://codereview.chromium.org/2480843002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart#newcode408 pkg/analysis_server/lib/src/edit/edit_domain.dart:408: class _DartAssistContextForValues implements DartAssistContext { Can you clarify ...
4 years, 1 month ago (2016-11-04 23:25:27 UTC) #2
scheglov
https://codereview.chromium.org/2480843002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart File pkg/analysis_server/lib/src/edit/edit_domain.dart (right): https://codereview.chromium.org/2480843002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart#newcode408 pkg/analysis_server/lib/src/edit/edit_domain.dart:408: class _DartAssistContextForValues implements DartAssistContext { On 2016/11/04 23:25:27, Paul ...
4 years, 1 month ago (2016-11-04 23:49:20 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 9f6e57635a5f97abefadfc2ffaebfdb862347461 (presubmit successful).
4 years, 1 month ago (2016-11-04 23:50:32 UTC) #5
Brian Wilkerson
4 years, 1 month ago (2016-11-06 17:41:14 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698