Support for Quick Assists with the new analysis driver.

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library edit.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/edit/assist/assist_core.dart';
+import 'package:analysis_server/plugin/edit/assist/assist_dart.dart';
 import 'package:analysis_server/plugin/edit/fix/fix_core.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/collections.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol_server.dart' hide Element;
 import 'package:analysis_server/src/services/correction/assist.dart';
+import 'package:analysis_server/src/services/correction/assist_internal.dart';
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analysis_server/src/services/correction/organize_directives.dart';
 import 'package:analysis_server/src/services/correction/sort_members.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart' as engine;
 import 'package:analyzer/src/dart/analysis/driver.dart';
@@ skipping 99 matching lines @@
     }
     if (newLength == null) {
       newLength = 0;
     }
 
     return new EditFormatResult(edits, newStart, newLength)
         .toResponse(request.id);
   }
 
   Future getAssists(Request request) async {
+    EditGetAssistsParams params = new EditGetAssistsParams.fromRequest(request);
+    List<Assist> assists;
     if (server.options.enableNewAnalysisDriver) {
-      // TODO(scheglov) implement for the new analysis driver
-      return;
+      AnalysisResult result = await server.getAnalysisResult(params.file);
+      CompilationUnit unit = result.unit;
+      DartAssistContext dartAssistContext = new _DartAssistContextForValues(
+          unit.element.source,
+          params.offset,
+          params.length,
+          unit.element.context,
+          unit);
+      try {
+        AssistProcessor processor = new AssistProcessor(dartAssistContext);
+        assists = await processor.compute();
+      } catch (_) {}
+    } else {
+      ContextSourcePair pair = server.getContextSourcePair(params.file);
+      engine.AnalysisContext context = pair.context;
+      Source source = pair.source;
+      if (context != null && source != null) {
+        assists = await computeAssists(
+            server.serverPlugin, context, source, params.offset, params.length);
+      }
     }
-    EditGetAssistsParams params = new EditGetAssistsParams.fromRequest(request);
-    ContextSourcePair pair = server.getContextSourcePair(params.file);
-    engine.AnalysisContext context = pair.context;
-    Source source = pair.source;
+    // Send the assist changes.
     List<SourceChange> changes = <SourceChange>[];
-    if (context != null && source != null) {
-      List<Assist> assists = await computeAssists(
-          server.serverPlugin, context, source, params.offset, params.length);
-      assists.forEach((Assist assist) {
-        changes.add(assist.change);
-      });
-    }
+    assists?.forEach((Assist assist) {
+      changes.add(assist.change);
+    });
     Response response =
         new EditGetAssistsResult(changes).toResponse(request.id);
     server.sendResponse(response);
   }
 
   Future getFixes(Request request) async {
     if (server.options.enableNewAnalysisDriver) {
       // TODO(scheglov) implement for the new analysis driver
       return;
     }
@@ skipping 222 matching lines @@
     for (engine.AnalysisError error in errors) {
       if (error.errorCode is engine.ScannerErrorCode ||
           error.errorCode is engine.ParserErrorCode) {
         numScanParseErrors++;
       }
     }
     return numScanParseErrors;
   }
 }
 
+class _DartAssistContextForValues implements DartAssistContext {

[Paul Berry, 2016/11/04 23:25:27]

Can you clarify what "ForValues" means?

[scheglov, 2016/11/04 23:49:20]

I will add a documentation comment.

+  @override
+  final Source source;
+
+  @override
+  final int selectionOffset;
+
+  @override
+  final int selectionLength;
+
+  @override
+  final engine.AnalysisContext analysisContext;
+
+  @override
+  final CompilationUnit unit;
+
+  _DartAssistContextForValues(this.source, this.selectionOffset,
+      this.selectionLength, this.analysisContext, this.unit);
+}
+
 /**
  * An object managing a single [Refactoring] instance.
  *
  * The instance is identified by its kind, file, offset and length.
  * It is initialized when the a set of parameters is given for the first time.
  * All subsequent requests are performed on this [Refactoring] instance.
  *
  * Once new set of parameters is received, the previous [Refactoring] instance
  * is invalidated and a new one is created and initialized.
  */
@@ skipping 429 matching lines @@
     }
     return new RefactoringStatus();
   }
 }
 
 /**
  * [_RefactoringManager] throws instances of this class internally to stop
  * processing in a manager that was reset.
  */
 class _ResetError {}